linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	swboyd@chromium.org, linux-gpio@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Show correct direction from the beginning
Date: Thu, 20 Sep 2018 07:25:17 -0500	[thread overview]
Message-ID: <ebcc344a-469a-d3c0-3e0e-cdabe046cbf3@kernel.org> (raw)
In-Reply-To: <CAPybu_39xtDfoHVo2dv2GZcU5hCQYjBpU7tW2hf3vfUwbUK1mQ@mail.gmail.com>

On 9/19/18 10:27 AM, Ricardo Ribalda Delgado wrote:
> "The get_direction callback normally triggers
> a  read/write to hardware, but we shouldn't be touching the hardware
> for   an individual GPIO until after it's been properly claimed." is
> an statement specific for your platform 

That is definitely not true.

> and should be fixed in your
> driver.

There is no bug in my driver.  The driver reports only a subset of the 
GPIOs, because that's all that are available.  Attempting to access an 
invalid GPIO generates an XPU violation.  The original code was 
attempting to access GPIOs that the driver said don't exist.

The code that we have today is the result of months of discussion, 
negotiation, and trial-and-error.

  parent reply	other threads:[~2018-09-20 12:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  7:08 [RFC] gpiolib: Fix gpio_direction_* for single direction GPIOs Ricardo Ribalda Delgado
2018-09-14  7:08 ` [PATCH] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-09-18 22:40   ` Linus Walleij
2018-09-19  4:04     ` Ricardo Ribalda Delgado
2018-09-19 11:50       ` Timur Tabi
2018-09-19 15:27         ` Ricardo Ribalda Delgado
2018-09-20 12:20           ` Timur Tabi
2018-09-20 14:14             ` Ricardo Ribalda Delgado
2018-09-20 22:43               ` Linus Walleij
2018-09-20 12:25           ` Timur Tabi [this message]
2018-09-20  5:23         ` Linus Walleij
2018-09-20 12:35           ` Timur Tabi
2018-09-20 22:36             ` Linus Walleij
2018-09-21  2:05               ` Timur Tabi
2018-09-21 16:07                 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebcc344a-469a-d3c0-3e0e-cdabe046cbf3@kernel.org \
    --to=timur@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).