From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>,
Henry Sun <henrysun@google.com>,
Bob Moragues <moragues@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
Date: Wed, 20 Jul 2022 18:55:27 +0200 [thread overview]
Message-ID: <bcbca05e-2b75-a405-b1ea-21b276931a90@linaro.org> (raw)
In-Reply-To: <CAD=FV=V1MqQzNxq_L8sGtu2JwAAL_FWKXkw9bhCHcD0DycFMUw@mail.gmail.com>
On 20/07/2022 17:13, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/07/2022 04:51, Yunlong Jia wrote:
>>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>>>
>>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>>> ---
>>>
>>> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> index 764c451c1a857..4649eaec6318d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> @@ -14,7 +14,7 @@
>>>
>>> / {
>>> model = "Google Pazquel (Parade,LTE)";
>>> - compatible = "google,pazquel-sku4", "qcom,sc7180";
>>> + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
>>
>> You miss binding change and sku6 should be rather added before sku4 as
>> it is more specific, isn't it?
>
> Just to close the loop: the order doesn't matter at all. Neither sku4
> nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
Thanks Doug. Then the commit description could be improved, so reviewer
does not have to ask such questions. Otherwise it is confusing to see a
board which says it is for LTE version but it is actually not for LTE
version (or whatever combination you have).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-20 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 2:51 [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Yunlong Jia
2022-07-20 6:10 ` Krzysztof Kozlowski
2022-07-20 15:13 ` Doug Anderson
2022-07-20 16:55 ` Krzysztof Kozlowski [this message]
2022-07-20 17:53 ` Doug Anderson
2022-07-20 17:55 ` Krzysztof Kozlowski
2022-07-20 7:37 Yunlong Jia
2022-07-20 7:45 ` Krzysztof Kozlowski
2022-07-20 15:11 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbca05e-2b75-a405-b1ea-21b276931a90@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=henrysun@google.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=yunlong.jia@ecs.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).