linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 7/7] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth firmware loading
@ 2022-10-16 14:34 Caleb Connolly
  2022-10-16 14:58 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Caleb Connolly @ 2022-10-16 14:34 UTC (permalink / raw)
  To: caleb
  Cc: Dylan Van Assche, Alexander Martinz, Andy Gross, Bjorn Andersson,
	devicetree, Konrad Dybcio, Krzysztof Kozlowski, linux-arm-msm,
	linux-kernel, Rob Herring

From: Dylan Van Assche <me@dylanvanassche.be>

Add serial1 alias, firmware name and use 4 pin UART pinmux.

Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
Tested-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 83261c9bb4f2..3e038156af4f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -22,6 +22,7 @@ / {

 	aliases {
 		display0 = &framebuffer0;
+		serial1 = &uart6;
 		serial0 = &uart9;
 	};

@@ -693,9 +694,17 @@ config {
 &uart6 {
 	status = "okay";

+	pinctrl-0 = <&qup_uart6_4pin>;
+
 	bluetooth {
 		compatible = "qcom,wcn3990-bt";

+		/*
+		 * This path is relative to the qca/
+		 * subdir under lib/firmware.
+		 */
+		firmware-name = "axolotl/crnv21.bin";
+
 		vddio-supply = <&vreg_s4a_1p8>;
 		vddxo-supply = <&vreg_l7a_1p8>;
 		vddrf-supply = <&vreg_l17a_1p3>;
--
2.38.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 7/7] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth firmware loading
  2022-10-16 14:34 [PATCH 7/7] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth firmware loading Caleb Connolly
@ 2022-10-16 14:58 ` Krzysztof Kozlowski
  2022-10-16 15:00   ` Caleb Connolly
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-16 14:58 UTC (permalink / raw)
  To: Caleb Connolly
  Cc: Dylan Van Assche, Alexander Martinz, Andy Gross, Bjorn Andersson,
	devicetree, Konrad Dybcio, Krzysztof Kozlowski, linux-arm-msm,
	linux-kernel, Rob Herring

On 16/10/2022 10:34, Caleb Connolly wrote:
> From: Dylan Van Assche <me@dylanvanassche.be>
> 
> Add serial1 alias, firmware name and use 4 pin UART pinmux.
> 
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> Tested-by: Alexander Martinz <amartinz@shiftphones.com>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>

All your patches - except 1 - are not properly threaded.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 7/7] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth firmware loading
  2022-10-16 14:58 ` Krzysztof Kozlowski
@ 2022-10-16 15:00   ` Caleb Connolly
  0 siblings, 0 replies; 3+ messages in thread
From: Caleb Connolly @ 2022-10-16 15:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dylan Van Assche, Alexander Martinz, Andy Gross, Bjorn Andersson,
	devicetree, Konrad Dybcio, Krzysztof Kozlowski, linux-arm-msm,
	linux-kernel, Rob Herring



On 16/10/2022 15:58, Krzysztof Kozlowski wrote:
> On 16/10/2022 10:34, Caleb Connolly wrote:
>> From: Dylan Van Assche <me@dylanvanassche.be>
>>
>> Add serial1 alias, firmware name and use 4 pin UART pinmux.
>>
>> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
>> Tested-by: Alexander Martinz <amartinz@shiftphones.com>
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
>
> All your patches - except 1 - are not properly threaded.

Sorry about that! It seems that Protonmail have decided to break In-Reply-To
again... I resent the series with threading here:

https://lore.kernel.org/linux-arm-msm/20221016144714.1742824-1-kc@postmarketos.org/T/#t

>
> Best regards,
> Krzysztof
>

--
Kind Regards,
Caleb


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-16 15:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-16 14:34 [PATCH 7/7] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth firmware loading Caleb Connolly
2022-10-16 14:58 ` Krzysztof Kozlowski
2022-10-16 15:00   ` Caleb Connolly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).