linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: Re: [RFC PATCH v1 5/5] arm64: tegra: Add Tegra VI CSI suppport in device tree
Date: Wed, 29 Jan 2020 08:22:48 -0800	[thread overview]
Message-ID: <bd18711d-ce23-cbee-7824-37a8c78908e6@nvidia.com> (raw)
In-Reply-To: <20200129094624.GD2479935@ulmo>


On 1/29/20 1:46 AM, Thierry Reding wrote:
> On Tue, Jan 28, 2020 at 10:23:21AM -0800, Sowjanya Komatineni wrote:
>> Tegra210 contains VI controller for video input capture from MIPI
>> CSI camera sensors and also supports built-in test pattern generator.
>>
>> CSI ports can be one-to-one mapped to VI channels for capturing from
>> an external sensor or from built-in test pattern generator.
>>
>> This patch adds support for VI and CSI and enables them in Tegra210
>> device tree.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi |  8 +++++++
>>   arch/arm64/boot/dts/nvidia/tegra210.dtsi       | 31 +++++++++++++++++++++++++-
>>   2 files changed, 38 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> index b0095072bc28..ec1b3033fa03 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> @@ -10,6 +10,14 @@
>>   			status = "okay";
>>   		};
>>   
>> +		vi@54080000 {
>> +			status = "okay";
>> +		};
>> +
>> +		csi@0x54080838 {
>> +			status = "okay";
>> +		};
>> +
>>   		sor@54580000 {
>>   			status = "okay";
>>   
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> index 48c63256ba7f..c6107ec03ad1 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> @@ -136,9 +136,38 @@
>>   
>>   		vi@54080000 {
>>   			compatible = "nvidia,tegra210-vi";
>> -			reg = <0x0 0x54080000 0x0 0x00040000>;
>> +			reg = <0x0 0x54080000 0x0 0x808>;
>>   			interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>>   			status = "disabled";
>> +			assigned-clocks = <&tegra_car TEGRA210_CLK_VI>;
>> +			assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_C4_OUT0>;
>> +
>> +			clocks = <&tegra_car TEGRA210_CLK_VI>;
>> +			clock-names = "vi";
>> +			resets = <&tegra_car 20>;
>> +			reset-names = "vi";
>> +		};
>> +
>> +		csi@0x54080838 {
>> +			compatible = "nvidia,tegra210-csi";
>> +			reg = <0x0 0x54080838 0x0 0x2000>;
>> +			status = "disabled";
>> +			assigned-clocks = <&tegra_car TEGRA210_CLK_CILAB>,
>> +					  <&tegra_car TEGRA210_CLK_CILCD>,
>> +					  <&tegra_car TEGRA210_CLK_CILE>;
>> +			assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_P>,
>> +						 <&tegra_car TEGRA210_CLK_PLL_P>,
>> +						 <&tegra_car TEGRA210_CLK_PLL_P>;
>> +			assigned-clock-rates = <102000000>,
>> +					       <102000000>,
>> +					       <102000000>;
>> +
>> +			clocks = <&tegra_car TEGRA210_CLK_CSI>,
>> +				 <&tegra_car TEGRA210_CLK_CILAB>,
>> +				 <&tegra_car TEGRA210_CLK_CILCD>,
>> +				 <&tegra_car TEGRA210_CLK_CILE>;
>> +			clock-names = "csi", "cilab", "cilcd", "cile";
>> +
>>   		};
> Can this be a child of the vi node? Looking at the register ranges it
> seems like these are actually a single IP block. If they have separate
> blocks with clearly separate functionality, then it makes sense to have
> CSI be a child node of VI, though it may also be okay to merge both and
> have a single node with the driver doing all of the differentiation
> between what's VI and what's CSI.
>
> Looking at later chips, the split between VI and CSI is more explicit,
> so having the split in DT for Tegra210 may make sense for consistency.
>
> I know we've discussed this before, but for some reason I keep coming
> back to this. I'll go through the other patches to see if I can get a
> clearer picture of how this could all work together.
>
> Thierry

We can keep it separate as we discussed.

But as Tegra186 onwards, CSI is separate device to be all cosistent I 
kept CSI as separate node for Tegra210 as well.


  reply	other threads:[~2020-01-29 16:22 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 18:23 [RFC PATCH v1 0/5] Add Tegra driver for video capture Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 1/5] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-02-05 19:23   ` Stephen Boyd
2020-01-28 18:23 ` [RFC PATCH v1 2/5] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-02-05 19:23   ` Stephen Boyd
2020-01-28 18:23 ` [RFC PATCH v1 3/5] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-01-28 20:32   ` Helen Koike
2020-01-28 21:04     ` Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 4/5] media: tegra: Add Tegra Video input driver for Tegra210 Sowjanya Komatineni
2020-01-28 21:45   ` Helen Koike
2020-01-28 22:13     ` Sowjanya Komatineni
2020-01-29  0:49       ` Sowjanya Komatineni
2020-01-29  1:05         ` Helen Koike
2020-01-29  2:11           ` Sowjanya Komatineni
2020-01-29  5:59             ` Sowjanya Komatineni
2020-01-29 10:31             ` Helen Koike
2020-01-29 17:49               ` Sowjanya Komatineni
2020-01-29 18:15                 ` Sowjanya Komatineni
2020-01-29 18:46                   ` Helen Koike
2020-01-29 22:40                     ` Sowjanya Komatineni
2020-01-29 18:29                 ` Helen Koike
2020-01-29 18:46                   ` Sowjanya Komatineni
2020-01-29 10:09       ` Thierry Reding
2020-01-29 16:25         ` Sowjanya Komatineni
2020-01-29 11:13   ` Thierry Reding
2020-01-29 17:23     ` Sowjanya Komatineni
2020-01-30 12:20       ` Thierry Reding
2020-01-30 17:02         ` Sowjanya Komatineni
2020-01-29 14:16   ` Hans Verkuil (hansverk)
2020-01-29 17:27     ` Sowjanya Komatineni
2020-01-30 14:45   ` Hans Verkuil
2020-02-05 19:26   ` Stephen Boyd
2020-02-05 19:54     ` Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 5/5] arm64: tegra: Add Tegra VI CSI suppport in device tree Sowjanya Komatineni
2020-01-29  9:46   ` Thierry Reding
2020-01-29 16:22     ` Sowjanya Komatineni [this message]
2020-01-30 12:36       ` Thierry Reding
2020-01-30 17:18         ` Sowjanya Komatineni
2020-01-30 17:58           ` Thierry Reding
2020-01-30 18:58             ` Sowjanya Komatineni
2020-01-30 20:18               ` Sowjanya Komatineni
2020-01-31  2:57                 ` Sowjanya Komatineni
2020-01-30 14:41 ` [RFC PATCH v1 0/5] Add Tegra driver for video capture Hans Verkuil
2020-01-30 15:42   ` Thierry Reding
2020-01-31 14:29     ` Hans Verkuil
2020-01-31 17:03       ` Thierry Reding
2020-01-31 17:37         ` Hans Verkuil
2020-01-31 20:31           ` Thierry Reding
2020-02-04  9:50         ` Hans Verkuil
2020-01-30 17:20   ` Sowjanya Komatineni
2020-02-04 12:53 ` Hans Verkuil
2020-02-04 16:42   ` Sowjanya Komatineni
2020-02-04 17:22     ` Hans Verkuil
2020-02-04 19:02       ` Sowjanya Komatineni
2020-02-05  7:57         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd18711d-ce23-cbee-7824-37a8c78908e6@nvidia.com \
    --to=skomatineni@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frankc@nvidia.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).