From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Keerthy <j-keerthy@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order
Date: Thu, 4 Mar 2021 22:57:02 +0200 [thread overview]
Message-ID: <bd551701-da42-8f9f-ad49-5d87baa9beec@ti.com> (raw)
In-Reply-To: <20210304072135.52712-2-tony@atomide.com>
On 04/03/2021 09:21, Tony Lindgren wrote:
> When the timer is configured in posted mode, we need to check the write-
> posted status register (TWPS) before writing to the register.
>
> We now check TWPS after the write starting with commit 52762fbd1c47
> ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource
> support").
>
> For example, in the TRM for am571x the following is documented in chapter
> "22.2.4.13.1.1 Write Posting Synchronization Mode":
>
> "For each register, a status bit is provided in the timer write-posted
> status (TWPS) register. In this mode, it is mandatory that software check
> this status bit before any write access. If a write is attempted to a
> register with a previous access pending, the previous access is discarded
> without notice."
>
> The regression happened when I updated the code to use standard read/write
> accessors for the driver instead of using __omap_dm_timer_load_start().
> We have__omap_dm_timer_load_start() check the TWPS status correctly using
> __omap_dm_timer_write().
>
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/clocksource/timer-ti-dm-systimer.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -449,13 +449,13 @@ static int dmtimer_set_next_event(unsigned long cycles,
> struct dmtimer_systimer *t = &clkevt->t;
> void __iomem *pend = t->base + t->pend;
>
> - writel_relaxed(0xffffffff - cycles, t->base + t->counter);
> while (readl_relaxed(pend) & WP_TCRR)
> cpu_relax();
> + writel_relaxed(0xffffffff - cycles, t->base + t->counter);
>
> - writel_relaxed(OMAP_TIMER_CTRL_ST, t->base + t->ctrl);
> while (readl_relaxed(pend) & WP_TCLR)
> cpu_relax();
> + writel_relaxed(OMAP_TIMER_CTRL_ST, t->base + t->ctrl);
It seems static [and inline] helper here could be better solution. no?
>
> return 0;
> }
> @@ -490,18 +490,18 @@ static int dmtimer_set_periodic(struct clock_event_device *evt)
> dmtimer_clockevent_shutdown(evt);
>
> /* Looks like we need to first set the load value separately */
> - writel_relaxed(clkevt->period, t->base + t->load);
> while (readl_relaxed(pend) & WP_TLDR)
> cpu_relax();
> + writel_relaxed(clkevt->period, t->base + t->load);
>
> - writel_relaxed(clkevt->period, t->base + t->counter);
> while (readl_relaxed(pend) & WP_TCRR)
> cpu_relax();
> + writel_relaxed(clkevt->period, t->base + t->counter);
>
> - writel_relaxed(OMAP_TIMER_CTRL_AR | OMAP_TIMER_CTRL_ST,
> - t->base + t->ctrl);
> while (readl_relaxed(pend) & WP_TCLR)
> cpu_relax();
> + writel_relaxed(OMAP_TIMER_CTRL_AR | OMAP_TIMER_CTRL_ST,
> + t->base + t->ctrl);
>
> return 0;
> }
>
--
Best regards,
grygorii
next prev parent reply other threads:[~2021-03-04 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 7:21 [PATCH 0/3] Fixes for timer-ti-dm systimer posted mode Tony Lindgren
2021-03-04 7:21 ` [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order Tony Lindgren
2021-03-04 20:57 ` Grygorii Strashko [this message]
2021-03-05 7:53 ` Tony Lindgren
2021-03-05 10:09 ` Grygorii Strashko
2021-04-09 10:27 ` [tip: timers/core] " tip-bot2 for Tony Lindgren
2021-03-04 7:21 ` [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put() Tony Lindgren
2021-03-04 20:55 ` Grygorii Strashko
2021-03-05 7:49 ` Tony Lindgren
2021-03-08 15:26 ` Tony Lindgren
2021-03-20 22:13 ` Daniel Lezcano
2021-03-04 7:21 ` [PATCH 3/3] clocksource/drivers/timer-ti-dm: Add missing set_state_oneshot_stopped Tony Lindgren
2021-04-09 10:27 ` [tip: timers/core] " tip-bot2 for Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd551701-da42-8f9f-ad49-5d87baa9beec@ti.com \
--to=grygorii.strashko@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).