* [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property
@ 2022-02-28 11:09 Kuldeep Singh
2022-02-28 21:31 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Kuldeep Singh @ 2022-02-28 11:09 UTC (permalink / raw)
To: Scott Branden, Ray Jui, devicetree, linux-arm-kernel, linux-kernel
Cc: Florian Fainelli, Anup Patel
Broadcom ns2 platform has spi-cpol and spi-cpho properties set
incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
of flag or boolean type and not integer type. Fix the values.
CC: Ray Jui <rjui@broadcom.com>
CC: Scott Branden <sbranden@broadcom.com>
CC: Florian Fainelli <f.fainelli@gmail.com>
Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
Hi,
This patch is on top of git://github.com/broadcom/cygnus-linux.git,
master branch which is not updated since 4.14 kernel.
Hope the reference is correct. Thanks!
arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
index ec19fbf928a1..12a4b1c03390 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
@@ -111,8 +111,8 @@
compatible = "silabs,si3226x";
reg = <0>;
spi-max-frequency = <5000000>;
- spi-cpha = <1>;
- spi-cpol = <1>;
+ spi-cpha;
+ spi-cpol;
pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,slave-tx-disable = <0>;
@@ -135,8 +135,8 @@
at25,byte-len = <0x8000>;
at25,addr-mode = <2>;
at25,page-size = <64>;
- spi-cpha = <1>;
- spi-cpol = <1>;
+ spi-cpha;
+ spi-cpol;
pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,slave-tx-disable = <0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property
2022-02-28 11:09 [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property Kuldeep Singh
@ 2022-02-28 21:31 ` Florian Fainelli
2022-03-02 13:07 ` Kuldeep Singh
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2022-02-28 21:31 UTC (permalink / raw)
To: Kuldeep Singh, Scott Branden, Ray Jui, devicetree,
linux-arm-kernel, linux-kernel
On 2/28/2022 3:09 AM, Kuldeep Singh wrote:
> Broadcom ns2 platform has spi-cpol and spi-cpho properties set
> incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
> of flag or boolean type and not integer type. Fix the values.
>
> CC: Ray Jui <rjui@broadcom.com>
> CC: Scott Branden <sbranden@broadcom.com>
> CC: Florian Fainelli <f.fainelli@gmail.com>
> Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> Hi,
>
> This patch is on top of git://github.com/broadcom/cygnus-linux.git,
> master branch which is not updated since 4.14 kernel.
> Hope the reference is correct. Thanks!
The reference is not correct, but it applied cleanly anyway. The correct
reference would have been the github.com/Broadcom/stblinux
refs/heads/devicetree-arm64/next
Applied, thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property
2022-02-28 21:31 ` Florian Fainelli
@ 2022-03-02 13:07 ` Kuldeep Singh
0 siblings, 0 replies; 3+ messages in thread
From: Kuldeep Singh @ 2022-03-02 13:07 UTC (permalink / raw)
To: Florian Fainelli
Cc: Scott Branden, Ray Jui, devicetree, linux-arm-kernel, linux-kernel
On Mon, Feb 28, 2022 at 01:31:50PM -0800, Florian Fainelli wrote:
>
>
> On 2/28/2022 3:09 AM, Kuldeep Singh wrote:
> > Broadcom ns2 platform has spi-cpol and spi-cpho properties set
> > incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
> > of flag or boolean type and not integer type. Fix the values.
> >
> > CC: Ray Jui <rjui@broadcom.com>
> > CC: Scott Branden <sbranden@broadcom.com>
> > CC: Florian Fainelli <f.fainelli@gmail.com>
> > Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> > Hi,
> >
> > This patch is on top of git://github.com/broadcom/cygnus-linux.git,
> > master branch which is not updated since 4.14 kernel.
> > Hope the reference is correct. Thanks!
>
> The reference is not correct, but it applied cleanly anyway. The correct
> reference would have been the github.com/Broadcom/stblinux
> refs/heads/devicetree-arm64/next
Thanks Florian for mentioning.
I took a quick look at MAINTAINERS file before sending patch and found
cygnus-linux repo as base reference. It seems the correct reference is
not updated in MAINTAINERS file.
>
> Applied, thanks!
Thanks!
--
Best Regards
Kuldeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-02 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 11:09 [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property Kuldeep Singh
2022-02-28 21:31 ` Florian Fainelli
2022-03-02 13:07 ` Kuldeep Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).