From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v2 09/13] xen/pvcalls: implement recvmsg
Date: Wed, 26 Jul 2017 17:33:34 -0400 [thread overview]
Message-ID: <bdeca082-1a40-e57c-c72c-30cd0a220b93@oracle.com> (raw)
In-Reply-To: <3485ca4d-9c8f-fe0d-fc07-31578e370228@oracle.com>
>> + while (!(flags & MSG_DONTWAIT) && !pvcalls_front_read_todo(map)) {
>> + if (count < PVCALLS_FRONT_MAX_SPIN)
>> + count++;
>> + else
>> + wait_event_interruptible(map->active.inflight_conn_req,
>> + pvcalls_front_read_todo(map));
>> + }
> Should we be using PVCALLS_FRONT_MAX_SPIN here? In sendmsg it is
> counting non-sleeping iterations but here we are sleeping so
> PVCALLS_FRONT_MAX_SPIN (5000) may take a while.
>
> In fact, what shouldn't this waiting be a function of MSG_DONTWAIT
err, which it already is. But the question still stands (except for
MSG_DONTWAIT).
-boris
> and/or socket's O_NONBLOCK?
next prev parent reply other threads:[~2017-07-26 21:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:21 [PATCH v2 00/13] introduce the Xen PV Calls frontend Stefano Stabellini
2017-07-25 21:21 ` [PATCH v2 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-07-25 21:21 ` [PATCH v2 02/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-07-26 13:35 ` Boris Ostrovsky
2017-07-27 0:26 ` Stefano Stabellini
2017-07-27 15:07 ` Boris Ostrovsky
2017-07-31 21:55 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 03/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-07-26 14:27 ` Boris Ostrovsky
2017-07-26 23:19 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 04/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-07-26 14:51 ` Boris Ostrovsky
2017-07-26 23:22 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 05/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-07-26 14:56 ` Boris Ostrovsky
2017-07-26 23:59 ` Stefano Stabellini
2017-07-27 14:43 ` Boris Ostrovsky
2017-07-31 22:17 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 06/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 07/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-07-26 17:52 ` Boris Ostrovsky
2017-07-26 23:24 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 08/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 09/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-07-26 21:21 ` Boris Ostrovsky
2017-07-26 21:33 ` Boris Ostrovsky [this message]
2017-07-27 0:08 ` [Xen-devel] " Stefano Stabellini
2017-07-27 14:59 ` Boris Ostrovsky
2017-07-31 22:26 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 10/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-07-26 23:23 ` Boris Ostrovsky
2017-07-27 0:21 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 11/13] xen/pvcalls: implement release command Stefano Stabellini
2017-07-27 18:39 ` Boris Ostrovsky
2017-07-31 22:34 ` Stefano Stabellini
2017-08-01 15:23 ` Boris Ostrovsky
2017-08-01 15:34 ` Juergen Gross
2017-08-01 15:57 ` Boris Ostrovsky
2017-09-11 23:56 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 12/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdeca082-1a40-e57c-c72c-30cd0a220b93@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).