From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 4/6] soundwire: qcom: start the clock during initialization
Date: Mon, 1 Feb 2021 15:50:36 +0000 [thread overview]
Message-ID: <bdedf84c-68fd-767d-8b3b-5a6ba03e03d8@linaro.org> (raw)
In-Reply-To: <20210201142134.GC2771@vkoul-mobl>
On 01/02/2021 14:21, Vinod Koul wrote:
> On 29-01-21, 17:32, Srinivas Kandagatla wrote:
>> Start the clock during initialization.
>
> A detailed log please, which clock..? Also how do older controllers work
> w/o this clk
By default this is ON, however depending on that is not really reliable!
Explicitly enabling this will make things clear when we add clk pause
feature for this driver!
--srini
>
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/soundwire/qcom.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index 3669bac11a32..83df15d83935 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -47,6 +47,8 @@
>> #define SWRM_MCP_FRAME_CTRL_BANK_ADDR(m) (0x101C + 0x40 * (m))
>> #define SWRM_MCP_FRAME_CTRL_BANK_COL_CTRL_BMSK GENMASK(2, 0)
>> #define SWRM_MCP_FRAME_CTRL_BANK_ROW_CTRL_BMSK GENMASK(7, 3)
>> +#define SWRM_MCP_BUS_CTRL 0x1044
>> +#define SWRM_MCP_BUS_CLK_START BIT(1)
>> #define SWRM_MCP_CFG_ADDR 0x1048
>> #define SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK GENMASK(21, 17)
>> #define SWRM_DEF_CMD_NO_PINGS 0x1f
>> @@ -345,6 +347,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
>> u32p_replace_bits(&val, SWRM_DEF_CMD_NO_PINGS, SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK);
>> ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val);
>>
>> + ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START);
>> /* Configure number of retries of a read/write cmd */
>> if (ctrl->version_major == 1 && ctrl->version_minor >= 5 &&
>> ctrl->version_step >= 1) {
>> --
>> 2.21.0
>
next prev parent reply other threads:[~2021-02-01 15:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:32 [PATCH 0/6] soundwire: qcom: various improvements Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 1/6] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-01-29 19:20 ` Pierre-Louis Bossart
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-01 16:33 ` Pierre-Louis Bossart
2021-02-01 14:13 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 2/6] soundwire: qcom: extract version field Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-01-29 19:21 ` Pierre-Louis Bossart
2021-02-01 14:16 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-02 4:46 ` Vinod Koul
2021-01-29 17:32 ` [PATCH 4/6] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-02-01 14:21 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla [this message]
2021-02-02 4:46 ` Vinod Koul
2021-01-29 17:32 ` [PATCH 5/6] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-01-29 19:33 ` Pierre-Louis Bossart
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-01 16:42 ` Pierre-Louis Bossart
2021-02-02 10:19 ` Srinivas Kandagatla
2021-02-02 16:58 ` Pierre-Louis Bossart
2021-02-01 14:26 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 6/6] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-01-29 19:38 ` Pierre-Louis Bossart
2021-02-01 15:51 ` Srinivas Kandagatla
2021-02-01 14:31 ` Vinod Koul
2021-02-01 15:51 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdedf84c-68fd-767d-8b3b-5a6ba03e03d8@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).