* [PATCH] staging: media: soc_camera: Enclose macro with parentheses
@ 2020-04-24 19:56 Guilherme Ricioli
2020-06-24 11:46 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Guilherme Ricioli @ 2020-04-24 19:56 UTC (permalink / raw)
To: linux-media; +Cc: lkcamp, devel, linux-kernel, mchehab, gregkh, hverkuil-cisco
Fix checkpatch error "ERROR: Macros with complex values should be
enclosed in parentheses" in soc_camera.c:241.
Signed-off-by: Guilherme Ricioli <guilherme.riciolic@gmail.com>
---
drivers/staging/media/soc_camera/soc_camera.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/staging/media/soc_camera/soc_camera.c
index 39f513f..c2f96ea 100644
--- a/drivers/staging/media/soc_camera/soc_camera.c
+++ b/drivers/staging/media/soc_camera/soc_camera.c
@@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_subdev_desc *ssdd,
}
EXPORT_SYMBOL(soc_camera_apply_board_flags);
-#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
- ((x) >> 24) & 0xff
+#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
+ ((x) >> 24) & 0xff)
static int soc_camera_try_fmt(struct soc_camera_device *icd,
struct v4l2_format *f)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: soc_camera: Enclose macro with parentheses
2020-04-24 19:56 [PATCH] staging: media: soc_camera: Enclose macro with parentheses Guilherme Ricioli
@ 2020-06-24 11:46 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2020-06-24 11:46 UTC (permalink / raw)
To: Guilherme Ricioli, linux-media
Cc: lkcamp, devel, linux-kernel, mchehab, gregkh
On 24/04/2020 21:56, Guilherme Ricioli wrote:
> Fix checkpatch error "ERROR: Macros with complex values should be
> enclosed in parentheses" in soc_camera.c:241.
>
> Signed-off-by: Guilherme Ricioli <guilherme.riciolic@gmail.com>
> ---
> drivers/staging/media/soc_camera/soc_camera.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/staging/media/soc_camera/soc_camera.c
> index 39f513f..c2f96ea 100644
> --- a/drivers/staging/media/soc_camera/soc_camera.c
> +++ b/drivers/staging/media/soc_camera/soc_camera.c
> @@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_subdev_desc *ssdd,
> }
> EXPORT_SYMBOL(soc_camera_apply_board_flags);
>
> -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
> - ((x) >> 24) & 0xff
> +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
> + ((x) >> 24) & 0xff)
>
> static int soc_camera_try_fmt(struct soc_camera_device *icd,
> struct v4l2_format *f)
>
Thank you for the patch, but this driver is deprecated and in fact depends on BROKEN
(so it is never build).
Because of that I'll drop this patch.
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-24 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 19:56 [PATCH] staging: media: soc_camera: Enclose macro with parentheses Guilherme Ricioli
2020-06-24 11:46 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).