From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: linux@yadro.com, Nikita Shubin <n.shubin@yadro.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83867: fix get nvmem cell fail
Date: Fri, 5 Aug 2022 11:57:42 +0200 [thread overview]
Message-ID: <be6ee88d-1434-8ac0-5019-c50bf34a3306@rasmusvillemoes.dk> (raw)
In-Reply-To: <20220805084843.24542-1-nikita.shubin@maquefel.me>
On 05/08/2022 10.48, Nikita Shubin wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
>
> If CONFIG_NVMEM is not set of_nvmem_cell_get, of_nvmem_device_get
> functions will return ERR_PTR(-EOPNOTSUPP) and "failed to get nvmem
> cell io_impedance_ctrl" error would be reported despite "io_impedance_ctrl"
> is completely missing in Device Tree and we should use default values.
>
> Check -EOPNOTSUPP togather with -ENOENT to avoid this situation.
Ah, sorry about that, and thanks for catching.
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
next prev parent reply other threads:[~2022-08-05 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 8:48 [PATCH] net: phy: dp83867: fix get nvmem cell fail Nikita Shubin
2022-08-05 9:57 ` Rasmus Villemoes [this message]
2022-08-05 19:57 ` Andrew Lunn
2022-08-09 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6ee88d-1434-8ac0-5019-c50bf34a3306@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@yadro.com \
--cc=n.shubin@yadro.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).