* [PATCH v2 02/10] gcov: Replace strncmp with str_has_prefix
@ 2019-08-02 1:46 Chuhong Yuan
2019-08-02 11:45 ` Peter Oberparleiter
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-08-02 1:46 UTC (permalink / raw)
Cc: Peter Oberparleiter, linux-kernel, Chuhong Yuan
strncmp(str, const, len) is error-prone because len
is easy to have typo.
The example is the hard-coded len has counting error
or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix
to substitute such strncmp.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Revise the description.
kernel/gcov/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index e5eb5ea7ea59..67296c1768b4 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)
*/
static const char *deskew(const char *basename)
{
- if (strncmp(basename, SKEW_PREFIX, sizeof(SKEW_PREFIX) - 1) == 0)
+ if (str_has_prefix(basename, SKEW_PREFIX))
return basename + sizeof(SKEW_PREFIX) - 1;
return basename;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 02/10] gcov: Replace strncmp with str_has_prefix
2019-08-02 1:46 [PATCH v2 02/10] gcov: Replace strncmp with str_has_prefix Chuhong Yuan
@ 2019-08-02 11:45 ` Peter Oberparleiter
0 siblings, 0 replies; 2+ messages in thread
From: Peter Oberparleiter @ 2019-08-02 11:45 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-kernel
On 02.08.2019 03:46, Chuhong Yuan wrote:
> strncmp(str, const, len) is error-prone because len
> is easy to have typo.
> The example is the hard-coded len has counting error
> or sizeof(const) forgets - 1.
> So we prefer using newly introduced str_has_prefix
> to substitute such strncmp.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Looks sane!
Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>
> ---
> Changes in v2:
> - Revise the description.
>
> kernel/gcov/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
> index e5eb5ea7ea59..67296c1768b4 100644
> --- a/kernel/gcov/fs.c
> +++ b/kernel/gcov/fs.c
> @@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)
> */
> static const char *deskew(const char *basename)
> {
> - if (strncmp(basename, SKEW_PREFIX, sizeof(SKEW_PREFIX) - 1) == 0)
> + if (str_has_prefix(basename, SKEW_PREFIX))
> return basename + sizeof(SKEW_PREFIX) - 1;
> return basename;
> }
>
--
Peter Oberparleiter
Linux on Z Development - IBM Germany
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-02 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 1:46 [PATCH v2 02/10] gcov: Replace strncmp with str_has_prefix Chuhong Yuan
2019-08-02 11:45 ` Peter Oberparleiter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).