* [PATCH v2 0/2] Minor _OSC error handling improvements
@ 2015-12-15 16:37 Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
0 siblings, 2 replies; 3+ messages in thread
From: Andy Lutomirski @ 2015-12-15 16:37 UTC (permalink / raw)
To: linux-acpi, Rafael J. Wysocki, Len Brown
Cc: linux-kernel, Matthew Garrett, Bjorn Helgaas, linux-pci,
Yijing Wang, Andy Lutomirski
This time, I think I'm sending to the right people.
This doesn't fix any bugs, but it makes the debugging output a
little more useful.
Changes from v1:
- Added Bjorn's acks
- Split an overly long line
Andy Lutomirski (2):
acpi: Tidy up _OSC error spacing
acpi: Show _OSC UUID when _OSC fails
drivers/acpi/bus.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] acpi: Tidy up _OSC error spacing
2015-12-15 16:37 [PATCH v2 0/2] Minor _OSC error handling improvements Andy Lutomirski
@ 2015-12-15 16:37 ` Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Lutomirski @ 2015-12-15 16:37 UTC (permalink / raw)
To: linux-acpi, Rafael J. Wysocki, Len Brown
Cc: linux-kernel, Matthew Garrett, Bjorn Helgaas, linux-pci,
Yijing Wang, Andy Lutomirski
The whitespace in _OSC error reports is weird. Improve it.
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/acpi/bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index a212cefae524..2177ef0b16e4 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -182,12 +182,12 @@ static void acpi_print_osc_error(acpi_handle handle,
if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
printk(KERN_DEBUG "%s\n", error);
else {
- printk(KERN_DEBUG "%s:%s\n", (char *)buffer.pointer, error);
+ printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
kfree(buffer.pointer);
}
- printk(KERN_DEBUG"_OSC request data:");
+ printk(KERN_DEBUG "_OSC request data:");
for (i = 0; i < context->cap.length; i += sizeof(u32))
- printk("%x ", *((u32 *)(context->cap.pointer + i)));
+ printk(" %x", *((u32 *)(context->cap.pointer + i)));
printk("\n");
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] acpi: Show _OSC UUID when _OSC fails
2015-12-15 16:37 [PATCH v2 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
@ 2015-12-15 16:37 ` Andy Lutomirski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Lutomirski @ 2015-12-15 16:37 UTC (permalink / raw)
To: linux-acpi, Rafael J. Wysocki, Len Brown
Cc: linux-kernel, Matthew Garrett, Bjorn Helgaas, linux-pci,
Yijing Wang, Andy Lutomirski
When _OSC fails and especially when it fails due to an invalid UUID,
it's helpful to show the UUID that we tried.
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/acpi/bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 2177ef0b16e4..fcfdf6cbc6a8 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -180,9 +180,10 @@ static void acpi_print_osc_error(acpi_handle handle,
int i;
if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
- printk(KERN_DEBUG "%s\n", error);
+ printk(KERN_DEBUG "%s: %s\n", context->uuid_str, error);
else {
- printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
+ printk(KERN_DEBUG "%s (%s): %s\n",
+ (char *)buffer.pointer, context->uuid_str, error);
kfree(buffer.pointer);
}
printk(KERN_DEBUG "_OSC request data:");
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-15 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-15 16:37 [PATCH v2 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
2015-12-15 16:37 ` [PATCH v2 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).