linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* C/C++ Code Reviewer Available
@ 2020-12-31  7:45 Robin Rowe
  2020-12-31 18:20 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Robin Rowe @ 2020-12-31  7:45 UTC (permalink / raw)
  To: LKML

"Linux kernel's Kroah-Hartman: We're not struggling to get new coders, 
it's code review that's the bottleneck", says article at The Register.

Ok, I've used C++ for 20 years, taught C/C++ at two universities, and 
developed real-time safety-critical systems. Need me? Contact me off-list.

Rob
-- 
Robin Rowe
CinePaint Project Manager
Beverly Hills, California


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: C/C++ Code Reviewer Available
  2020-12-31  7:45 C/C++ Code Reviewer Available Robin Rowe
@ 2020-12-31 18:20 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2020-12-31 18:20 UTC (permalink / raw)
  To: Robin Rowe; +Cc: LKML

On Wed, Dec 30, 2020 at 11:45:58PM -0800, Robin Rowe wrote:
> "Linux kernel's Kroah-Hartman: We're not struggling to get new coders, it's
> code review that's the bottleneck", says article at The Register.
> 
> Ok, I've used C++ for 20 years, taught C/C++ at two universities, and
> developed real-time safety-critical systems. Need me? Contact me off-list.

Hi Robin,

It's great that you expressed an interest in contributing to the Linux
kernel!

How much experience do you have with Linux kernel coding?  Most code
reviewers specialize in a particular kernel subsystem, and often get
their start submitting patches as part of coming up to speed with that
particular subsystem so that a subsystem maintainer knows how much
they can trust a particular code review.

The real challenge is that we have plenty of people who are
enthusiastic about submitting whitespace patches and drive-by
checkpatch fixes, and/or submitting new drives or other features for
their particular employer, but we need to get them to graduate from
being entry-level coders, to being people who become senior developers
who can perform trusted code reviews --- and for their employers to
allow them to spend company time contributing back to the community.

Or for people who are willing to spend their own time on nights and
weekend doing this sort of code review work and/or bug fixes and/or
reviewing issues reported by fuzz testers or static code analyizers,
instead of just focusing on features that aren't part of drivers or
features that their companies need for their own short-term business
interest.  This does happen of course, for people who have become
super-passionate about contributing to the subsystem and the kernel
community at large, but there are many people who just submit device
drivers and/or specific kernel features because it's part of their 9-5
job.

This is most of what maintainers and other senior developers do; it's
the less glamorous "scut work" that fewer people are interested in ---
including implementing regression test frameworks, improving subsystem
documentation, investigating fuzz reports and hard-to-reproduce flaky
tests, helping to mentor and train newer engineers, and yes, code
review.  It's what's called servant-leadership.  :-)

Cheers,

				- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-31 18:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-31  7:45 C/C++ Code Reviewer Available Robin Rowe
2020-12-31 18:20 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).