* [PATCH] staging: atomisp: ov5693: constify acpi_device_id.
@ 2017-07-06 16:36 Arvind Yadav
0 siblings, 0 replies; only message in thread
From: Arvind Yadav @ 2017-07-06 16:36 UTC (permalink / raw)
To: mchehab, gregkh, alan; +Cc: linux-media, devel, linux-kernel
acpi_device_id are not supposed to change at runtime. All functions
working with acpi_device_id provided by <acpi/acpi_bus.h> work with
const acpi_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
20729 3264 0 23993 5db9
drivers/staging/media/atomisp/i2c/ov5693/ov5693.o
File size After adding 'const':
text data bss dec hex filename
20793 3200 0 23993 5db9
drivers/staging/media/atomisp/i2c/ov5693/ov5693.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
index 5e9dafe..2c79678 100644
--- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
@@ -2032,7 +2032,7 @@ static int ov5693_probe(struct i2c_client *client,
MODULE_DEVICE_TABLE(i2c, ov5693_id);
-static struct acpi_device_id ov5693_acpi_match[] = {
+static const struct acpi_device_id ov5693_acpi_match[] = {
{"INT33BE"},
{},
};
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-06 16:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 16:36 [PATCH] staging: atomisp: ov5693: constify acpi_device_id Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).