linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Yang Li <yang.lee@linux.alibaba.com>, michal.simek@xilinx.com
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()
Date: Tue, 21 Mar 2023 15:43:59 +0100	[thread overview]
Message-ID: <befeec9c-60ee-f13e-8bd1-9dd28c56811d@amd.com> (raw)
In-Reply-To: <20230316054325.108457-1-yang.lee@linux.alibaba.com>



On 3/16/23 06:43, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..0eea00d10545 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
>                  i2c->quirks = data->quirks;
>          }
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       i2c->base = devm_ioremap_resource(&pdev->dev, res);
> +       i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(i2c->base))
>                  return PTR_ERR(i2c->base);
> 
> --
> 2.20.1.7.g153144c
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

  reply	other threads:[~2023-03-21 14:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16  5:43 [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-21 14:43 ` Michal Simek [this message]
2023-03-29 19:14 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=befeec9c-60ee-f13e-8bd1-9dd28c56811d@amd.com \
    --to=michal.simek@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).