linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()
@ 2023-03-16  5:43 Yang Li
  2023-03-21 14:43 ` Michal Simek
  2023-03-29 19:14 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2023-03-16  5:43 UTC (permalink / raw)
  To: michal.simek; +Cc: linux-arm-kernel, linux-i2c, linux-kernel, Yang Li

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/i2c/busses/i2c-xiic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index dbb792fc197e..0eea00d10545 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
 		i2c->quirks = data->quirks;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	i2c->base = devm_ioremap_resource(&pdev->dev, res);
+	i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(i2c->base))
 		return PTR_ERR(i2c->base);
 
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()
  2023-03-16  5:43 [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource() Yang Li
@ 2023-03-21 14:43 ` Michal Simek
  2023-03-29 19:14 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2023-03-21 14:43 UTC (permalink / raw)
  To: Yang Li, michal.simek; +Cc: linux-arm-kernel, linux-i2c, linux-kernel



On 3/16/23 06:43, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..0eea00d10545 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
>                  i2c->quirks = data->quirks;
>          }
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       i2c->base = devm_ioremap_resource(&pdev->dev, res);
> +       i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(i2c->base))
>                  return PTR_ERR(i2c->base);
> 
> --
> 2.20.1.7.g153144c
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()
  2023-03-16  5:43 [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource() Yang Li
  2023-03-21 14:43 ` Michal Simek
@ 2023-03-29 19:14 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-03-29 19:14 UTC (permalink / raw)
  To: Yang Li; +Cc: michal.simek, linux-arm-kernel, linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

On Thu, Mar 16, 2023 at 01:43:25PM +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-29 19:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16  5:43 [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-21 14:43 ` Michal Simek
2023-03-29 19:14 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).