* [PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer()
@ 2022-02-18 18:53 Souptick Joarder
2022-02-21 7:06 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2022-02-18 18:53 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
nathan, desaulniers, Felix.Kuehling, Oak.Zeng, nirmoy.das,
jonathan.kim, kevin1.wang, tzimmermann, Philip.Yang
Cc: amd-gfx, dri-devel, linux-kernel, llvm, Souptick Joarder (HPE),
kernel test robot
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
Kernel test robot reported warning ->
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2129:2: warning: Undefined
or garbage value returned to caller [clang-analyzer-core.
uninitialized.UndefReturn]
Initialize r inside amdgpu_fill_buffer().
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 414a22dddc78..5fafb223177f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2089,7 +2089,7 @@ int amdgpu_fill_buffer(struct amdgpu_bo *bo,
struct amdgpu_ring *ring = adev->mman.buffer_funcs_ring;
struct dma_fence *fence = NULL;
struct amdgpu_res_cursor dst;
- int r;
+ int r = 0;
if (!adev->mman.buffer_funcs_enabled) {
DRM_ERROR("Trying to clear memory with ring turned off.\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer()
2022-02-18 18:53 [PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer() Souptick Joarder
@ 2022-02-21 7:06 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2022-02-21 7:06 UTC (permalink / raw)
To: Souptick Joarder, alexander.deucher, Xinhui.Pan, airlied, daniel,
nathan, desaulniers, Felix.Kuehling, Oak.Zeng, nirmoy.das,
jonathan.kim, kevin1.wang, tzimmermann, Philip.Yang
Cc: amd-gfx, dri-devel, linux-kernel, llvm, kernel test robot
Am 18.02.22 um 19:53 schrieb Souptick Joarder:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot reported warning ->
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2129:2: warning: Undefined
> or garbage value returned to caller [clang-analyzer-core.
> uninitialized.UndefReturn]
Good catch, but that fix is usually seen as bad practice.
The warning is a false positive because the code path which would lead
to returning an undefined value can never happen. There is just no way
the compiler could know that.
I suggest to better initialize the return value directly before the
error handling to indicate that when we have reached this point we can
return success safely.
Regards,
Christian.
>
> Initialize r inside amdgpu_fill_buffer().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 414a22dddc78..5fafb223177f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -2089,7 +2089,7 @@ int amdgpu_fill_buffer(struct amdgpu_bo *bo,
> struct amdgpu_ring *ring = adev->mman.buffer_funcs_ring;
> struct dma_fence *fence = NULL;
> struct amdgpu_res_cursor dst;
> - int r;
> + int r = 0;
>
> if (!adev->mman.buffer_funcs_enabled) {
> DRM_ERROR("Trying to clear memory with ring turned off.\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-21 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 18:53 [PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer() Souptick Joarder
2022-02-21 7:06 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).