* Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
@ 2020-04-07 15:12 Markus Elfring
2020-04-08 8:06 ` Niklas Schnelle
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2020-04-07 15:12 UTC (permalink / raw)
To: Niklas Schnelle, netdev
Cc: linux-kernel, David S. Miller, Eran Ben Elisha, Leon Romanovsky,
Moshe Shemesh, Saeed Mahameed
> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
> allocation as done for the firmware tracer will always fail.
How do you think about to add the tag “Fixes” to the final change description?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
2020-04-07 15:12 [RFC] net/mlx5: Fix failing fw tracer allocation on s390 Markus Elfring
@ 2020-04-08 8:06 ` Niklas Schnelle
2020-04-08 19:38 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Schnelle @ 2020-04-08 8:06 UTC (permalink / raw)
To: Markus Elfring, netdev
Cc: linux-kernel, David S. Miller, Eran Ben Elisha, Leon Romanovsky,
Moshe Shemesh, Saeed Mahameed
On 4/7/20 5:12 PM, Markus Elfring wrote:
>> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
>> allocation as done for the firmware tracer will always fail.
>
> How do you think about to add the tag “Fixes” to the final change description?
>
> Regards,
> Markus
>
You're right that makes a lot of sense, thanks! I guess this should reference
the commit that introduced the debug trace, right?
Best regards,
Niklas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
2020-04-08 8:06 ` Niklas Schnelle
@ 2020-04-08 19:38 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-04-08 19:38 UTC (permalink / raw)
To: Markus.Elfring, schnelle, netdev
Cc: Eran Ben Elisha, linux-kernel, davem, leon, Moshe Shemesh
On Wed, 2020-04-08 at 10:06 +0200, Niklas Schnelle wrote:
> On 4/7/20 5:12 PM, Markus Elfring wrote:
> > > On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> > > kzalloc()
> > > allocation as done for the firmware tracer will always fail.
> >
> > How do you think about to add the tag “Fixes” to the final change
> > description?
> >
> > Regards,
> > Markus
> >
> You're right that makes a lot of sense, thanks! I guess this should
> reference
> the commit that introduced the debug trace, right?
>
probably, just git blame this line:
tracer = kzalloc(sizeof(*tracer), GFP_KERNEL);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-08 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 15:12 [RFC] net/mlx5: Fix failing fw tracer allocation on s390 Markus Elfring
2020-04-08 8:06 ` Niklas Schnelle
2020-04-08 19:38 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).