From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view
Date: Mon, 18 Nov 2019 20:30:13 +0800 [thread overview]
Message-ID: <bf27b851-d91c-8934-4c55-000b8e8f66a2@linux.intel.com> (raw)
In-Reply-To: <20191118104737.GF28372@krava>
On 11/18/2019 6:47 PM, Jiri Olsa wrote:
> On Sun, Nov 17, 2019 at 08:12:02PM +0800, Jin, Yao wrote:
>>
>>
>> On 11/15/2019 9:34 PM, Jiri Olsa wrote:
>>> On Wed, Nov 13, 2019 at 08:48:52AM +0800, Jin Yao wrote:
>>>> This patch supports jumping from tui total cycles view to symbol
>>>> source view.
>>>>
>>>> For example,
>>>>
>>>> perf record -b ./div
>>>> perf report --total-cycles
>>>>
>>>> In total cycles view, we can select one entry and press 'a' or
>>>> press ENTER key to jump to symbol source view.
>>>>
>>>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>>>> ---
>>>> tools/perf/builtin-report.c | 9 ++++++---
>>>> tools/perf/ui/browsers/hists.c | 25 +++++++++++++++++++++++--
>>>> tools/perf/util/block-info.c | 6 ++++--
>>>> tools/perf/util/block-info.h | 3 ++-
>>>> tools/perf/util/hist.h | 7 +++++--
>>>> 5 files changed, 40 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
>>>> index 1e81985b7d56..ceebea4013ca 100644
>>>> --- a/tools/perf/builtin-report.c
>>>> +++ b/tools/perf/builtin-report.c
>>>> @@ -493,7 +493,9 @@ static int perf_evlist__tui_block_hists_browse(struct evlist *evlist,
>>>> evlist__for_each_entry(evlist, pos) {
>>>> ret = report__browse_block_hists(&rep->block_reports[i++].hist,
>>>> - rep->min_percent, pos);
>>>> + rep->min_percent, pos,
>>>> + &rep->session->header.env,
>>>> + &rep->annotation_opts);
>>>> if (ret != 0)
>>>> return ret;
>>>> }
>>>> @@ -525,7 +527,8 @@ static int perf_evlist__tty_browse_hists(struct evlist *evlist,
>>>> if (rep->total_cycles_mode) {
>>>> report__browse_block_hists(&rep->block_reports[i++].hist,
>>>> - rep->min_percent, pos);
>>>> + rep->min_percent, pos,
>>>> + NULL, NULL);
>>>> continue;
>>>> }
>>>> @@ -1418,7 +1421,7 @@ int cmd_report(int argc, const char **argv)
>>>> if (sort__mode != SORT_MODE__BRANCH)
>>>> report.total_cycles_mode = false;
>>>> else
>>>> - sort_order = "sym";
>>>> + sort_order = NULL;
>>>
>>> hum, how is this related to this change?
>>>
>>> jirka
>>>
>>
>> Hi Jiri,
>>
>> If we set the sort_order to NULL, it will use the default branch sort order.
>> The percent value in new annotate view will be consistent with the percent
>> in annotate view which is switched from perf report.
>>
>> I observed the original percent gap with previous patches and then I decide
>> to use the default sort order. Now the test result looks good.
>
> ok, plz make note of it in changelog or comment
>
> thanks,
> jirka
>
OK, I see, thanks Jiri! I will post v2.
Thanks
Jin Yao
next prev parent reply other threads:[~2019-11-18 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 0:48 [PATCH v1 1/2] perf util: Move block tui function to ui browsers Jin Yao
2019-11-13 0:48 ` [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view Jin Yao
2019-11-15 13:34 ` Jiri Olsa
2019-11-17 12:12 ` Jin, Yao
2019-11-18 10:47 ` Jiri Olsa
2019-11-18 12:30 ` Jin, Yao [this message]
2019-11-15 13:34 ` Jiri Olsa
2019-11-17 12:12 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf27b851-d91c-8934-4c55-000b8e8f66a2@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).