From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view
Date: Sun, 17 Nov 2019 20:12:48 +0800 [thread overview]
Message-ID: <db38408d-1af4-3cf6-9d8f-91070cfa42d2@linux.intel.com> (raw)
In-Reply-To: <20191115133445.GB25491@krava>
On 11/15/2019 9:34 PM, Jiri Olsa wrote:
> On Wed, Nov 13, 2019 at 08:48:52AM +0800, Jin Yao wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
>> index e8b3122a30a7..5bf122042c01 100644
>> --- a/tools/perf/util/hist.h
>> +++ b/tools/perf/util/hist.h
>> @@ -478,7 +478,8 @@ int res_sample_browse(struct res_sample *res_samples, int num_res,
>> void res_sample_init(void);
>>
>> int block_hists_tui_browse(struct block_hist *bh, struct evsel *evsel,
>> - float min_percent);
>> + float min_percent, struct perf_env *env,
>> + struct annotation_options *annotation_opts);
>> #else
>> static inline
>> int perf_evlist__tui_browse_hists(struct evlist *evlist __maybe_unused,
>> @@ -525,7 +526,9 @@ static inline void res_sample_init(void) {}
>>
>> int block_hists_tui_browse(struct block_hist *bh __maybe_unused,
>> struct evsel *evsel __maybe_unused,
>> - float min_percent __maybe_unused)
>> + float min_percent __maybe_unused,
>> + struct perf_env *env __maybe_unused,
>> + struct annotation_options *annotation_opts)
>
> missing __maybe_unused, this breaks no-tui build 'make NO_SLANG=1'
>
> jirka
>
Oh, yes, I should add __maybe_unused.
Thanks
Jin Yao
prev parent reply other threads:[~2019-11-17 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 0:48 [PATCH v1 1/2] perf util: Move block tui function to ui browsers Jin Yao
2019-11-13 0:48 ` [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view Jin Yao
2019-11-15 13:34 ` Jiri Olsa
2019-11-17 12:12 ` Jin, Yao
2019-11-18 10:47 ` Jiri Olsa
2019-11-18 12:30 ` Jin, Yao
2019-11-15 13:34 ` Jiri Olsa
2019-11-17 12:12 ` Jin, Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db38408d-1af4-3cf6-9d8f-91070cfa42d2@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).