* [PATCH 1/3] RTC: rv3029: fix vendor string
@ 2017-09-15 2:00 Alexandre Belloni
2017-09-15 2:00 ` [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node Alexandre Belloni
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Alexandre Belloni @ 2017-09-15 2:00 UTC (permalink / raw)
To: linux-rtc
Cc: linux-kernel, linux-arm-kernel, Nicolas Ferre, Michael Ellerman,
Anatolij Gustschin, linuxppc-dev, Rob Herring, devicetree,
Alexandre Belloni
The vendor string for Microcrystal is microcrystal.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Documentation/devicetree/bindings/trivial-devices.txt | 2 +-
drivers/rtc/rtc-rv3029c2.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
index af284fbd4d23..aae37352c574 100644
--- a/Documentation/devicetree/bindings/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/trivial-devices.txt
@@ -72,7 +72,6 @@ isil,isl29030 Intersil ISL29030 Ambient Light and Proximity Sensor
maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
-mc,rv3029c2 Real Time Clock Module with I2C-Bus
mcube,mc3230 mCube 3-axis 8-bit digital accelerometer
memsic,mxc6225 MEMSIC 2-axis 8-bit digital accelerometer
microchip,mcp4531-502 Microchip 7-bit Single I2C Digital Potentiometer (5k)
@@ -141,6 +140,7 @@ microchip,mcp4662-503 Microchip 8-bit Dual I2C Digital Potentiometer with NV Mem
microchip,mcp4662-104 Microchip 8-bit Dual I2C Digital Potentiometer with NV Memory (100k)
microchip,tc654 PWM Fan Speed Controller With Fan Fault Detection
microchip,tc655 PWM Fan Speed Controller With Fan Fault Detection
+microcrystal,rv3029 Real Time Clock Module with I2C-Bus
miramems,da226 MiraMEMS DA226 2-axis 14-bit digital accelerometer
miramems,da280 MiraMEMS DA280 3-axis 14-bit digital accelerometer
miramems,da311 MiraMEMS DA311 3-axis 12-bit digital accelerometer
diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c
index aa09771de04f..cfe3aece51d1 100644
--- a/drivers/rtc/rtc-rv3029c2.c
+++ b/drivers/rtc/rtc-rv3029c2.c
@@ -876,6 +876,8 @@ static const struct i2c_device_id rv3029_id[] = {
MODULE_DEVICE_TABLE(i2c, rv3029_id);
static const struct of_device_id rv3029_of_match[] = {
+ { .compatible = "microcrystal,rv3029" },
+ /* Backward compatibility only, do not use compatibles below: */
{ .compatible = "rv3029" },
{ .compatible = "rv3029c2" },
{ .compatible = "mc,rv3029c2" },
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node
2017-09-15 2:00 [PATCH 1/3] RTC: rv3029: fix vendor string Alexandre Belloni
@ 2017-09-15 2:00 ` Alexandre Belloni
2017-09-15 7:08 ` Nicolas Ferre
2017-09-15 2:00 ` [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible Alexandre Belloni
2017-09-20 20:52 ` [PATCH 1/3] RTC: rv3029: fix vendor string Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Alexandre Belloni @ 2017-09-15 2:00 UTC (permalink / raw)
To: linux-rtc
Cc: linux-kernel, linux-arm-kernel, Nicolas Ferre, Michael Ellerman,
Anatolij Gustschin, linuxppc-dev, Rob Herring, devicetree,
Alexandre Belloni
The rv3029 compatible is missing its vendor string, add it.
Also fix the node name to be a proper generic name.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/usb_a9g20_common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/usb_a9g20_common.dtsi b/arch/arm/boot/dts/usb_a9g20_common.dtsi
index 088c2c3685ab..81c3fe0465d9 100644
--- a/arch/arm/boot/dts/usb_a9g20_common.dtsi
+++ b/arch/arm/boot/dts/usb_a9g20_common.dtsi
@@ -20,8 +20,8 @@
};
i2c-gpio-0 {
- rv3029c2@56 {
- compatible = "rv3029c2";
+ rtc@56 {
+ compatible = "microcrystal,rv3029";
reg = <0x56>;
};
};
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible
2017-09-15 2:00 [PATCH 1/3] RTC: rv3029: fix vendor string Alexandre Belloni
2017-09-15 2:00 ` [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node Alexandre Belloni
@ 2017-09-15 2:00 ` Alexandre Belloni
2017-09-15 7:13 ` Anatolij Gustschin
2017-09-20 20:52 ` [PATCH 1/3] RTC: rv3029: fix vendor string Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Alexandre Belloni @ 2017-09-15 2:00 UTC (permalink / raw)
To: linux-rtc
Cc: linux-kernel, linux-arm-kernel, Nicolas Ferre, Michael Ellerman,
Anatolij Gustschin, linuxppc-dev, Rob Herring, devicetree,
Alexandre Belloni
The proper compatible for rv3029 is microcrystal,rv3029.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/powerpc/boot/dts/digsy_mtc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/digsy_mtc.dts b/arch/powerpc/boot/dts/digsy_mtc.dts
index c280e75c86bf..c3922fc03e0b 100644
--- a/arch/powerpc/boot/dts/digsy_mtc.dts
+++ b/arch/powerpc/boot/dts/digsy_mtc.dts
@@ -78,7 +78,7 @@
};
rtc@56 {
- compatible = "mc,rv3029c2";
+ compatible = "microcrystal,rv3029";
reg = <0x56>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node
2017-09-15 2:00 ` [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node Alexandre Belloni
@ 2017-09-15 7:08 ` Nicolas Ferre
0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2017-09-15 7:08 UTC (permalink / raw)
To: Alexandre Belloni, linux-rtc
Cc: linux-kernel, linux-arm-kernel, Michael Ellerman,
Anatolij Gustschin, linuxppc-dev, Rob Herring, devicetree
On 15/09/2017 at 04:00, Alexandre Belloni wrote:
> The rv3029 compatible is missing its vendor string, add it.
> Also fix the node name to be a proper generic name.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> arch/arm/boot/dts/usb_a9g20_common.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/usb_a9g20_common.dtsi b/arch/arm/boot/dts/usb_a9g20_common.dtsi
> index 088c2c3685ab..81c3fe0465d9 100644
> --- a/arch/arm/boot/dts/usb_a9g20_common.dtsi
> +++ b/arch/arm/boot/dts/usb_a9g20_common.dtsi
> @@ -20,8 +20,8 @@
> };
>
> i2c-gpio-0 {
> - rv3029c2@56 {
> - compatible = "rv3029c2";
> + rtc@56 {
> + compatible = "microcrystal,rv3029";
> reg = <0x56>;
> };
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible
2017-09-15 2:00 ` [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible Alexandre Belloni
@ 2017-09-15 7:13 ` Anatolij Gustschin
2017-09-26 13:40 ` Alexandre Belloni
0 siblings, 1 reply; 7+ messages in thread
From: Anatolij Gustschin @ 2017-09-15 7:13 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-rtc, linux-kernel, linux-arm-kernel, Nicolas Ferre,
Michael Ellerman, linuxppc-dev, Rob Herring, devicetree
On Fri, 15 Sep 2017 04:00:04 +0200
Alexandre Belloni alexandre.belloni@free-electrons.com wrote:
>The proper compatible for rv3029 is microcrystal,rv3029.
>
>Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Anatolij Gustschin <agust@denx.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] RTC: rv3029: fix vendor string
2017-09-15 2:00 [PATCH 1/3] RTC: rv3029: fix vendor string Alexandre Belloni
2017-09-15 2:00 ` [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node Alexandre Belloni
2017-09-15 2:00 ` [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible Alexandre Belloni
@ 2017-09-20 20:52 ` Rob Herring
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2017-09-20 20:52 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-rtc, linux-kernel, linux-arm-kernel, Nicolas Ferre,
Michael Ellerman, Anatolij Gustschin, linuxppc-dev, devicetree
On Fri, Sep 15, 2017 at 04:00:02AM +0200, Alexandre Belloni wrote:
> The vendor string for Microcrystal is microcrystal.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.txt | 2 +-
> drivers/rtc/rtc-rv3029c2.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible
2017-09-15 7:13 ` Anatolij Gustschin
@ 2017-09-26 13:40 ` Alexandre Belloni
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Belloni @ 2017-09-26 13:40 UTC (permalink / raw)
To: Anatolij Gustschin
Cc: linux-rtc, linux-kernel, linux-arm-kernel, Nicolas Ferre,
Michael Ellerman, linuxppc-dev, Rob Herring, devicetree
Hi,
On 15/09/2017 at 09:13:26 +0200, Anatolij Gustschin wrote:
> On Fri, 15 Sep 2017 04:00:04 +0200
> Alexandre Belloni alexandre.belloni@free-electrons.com wrote:
>
> >The proper compatible for rv3029 is microcrystal,rv3029.
> >
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Acked-by: Anatolij Gustschin <agust@denx.de>
If that is fine for you, I would prefer that goes through your tree as
I'm not usually taking DT patches through the RTC tree. there is no
dependency as the i2c subsystem will already match the new compatible
with the i2c device_id.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-26 13:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-15 2:00 [PATCH 1/3] RTC: rv3029: fix vendor string Alexandre Belloni
2017-09-15 2:00 ` [PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node Alexandre Belloni
2017-09-15 7:08 ` Nicolas Ferre
2017-09-15 2:00 ` [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible Alexandre Belloni
2017-09-15 7:13 ` Anatolij Gustschin
2017-09-26 13:40 ` Alexandre Belloni
2017-09-20 20:52 ` [PATCH 1/3] RTC: rv3029: fix vendor string Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).