* [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"
@ 2020-03-30 10:16 Colin King
2020-03-30 17:21 ` David Miller
2020-03-30 17:52 ` Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-03-30 10:16 UTC (permalink / raw)
To: David S . Miller, Grygorii Strashko, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in a dev_err error message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 97f7385c6741..f71c15c39492 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1627,7 +1627,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
port->slave.mac_addr) ||
!is_valid_ether_addr(port->slave.mac_addr)) {
random_ether_addr(port->slave.mac_addr);
- dev_err(dev, "Use rundom MAC address\n");
+ dev_err(dev, "Use random MAC address\n");
}
}
of_node_put(node);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"
2020-03-30 10:16 [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random" Colin King
@ 2020-03-30 17:21 ` David Miller
2020-03-30 17:52 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-30 17:21 UTC (permalink / raw)
To: colin.king; +Cc: grygorii.strashko, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 30 Mar 2020 11:16:39 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a dev_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"
2020-03-30 10:16 [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random" Colin King
2020-03-30 17:21 ` David Miller
@ 2020-03-30 17:52 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-03-30 17:52 UTC (permalink / raw)
To: Colin King, David S . Miller, Grygorii Strashko, netdev
Cc: kernel-janitors, linux-kernel
On Mon, 2020-03-30 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a dev_err error message. Fix it.
[]
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
[]
> @@ -1627,7 +1627,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
> port->slave.mac_addr) ||
> !is_valid_ether_addr(port->slave.mac_addr)) {
> random_ether_addr(port->slave.mac_addr);
> - dev_err(dev, "Use rundom MAC address\n");
> + dev_err(dev, "Use random MAC address\n");
This continues without returning an error value.
Is this actually an error?
It might be useful to describe the slave and
random ethernet address too.
Perhaps:
dev_notice(dev, "%pOF slave[%d] using random MAC address %pM\n",
port_np, port_id, port->slave.mac_addr);
or maybe dev_info
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 10:16 [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random" Colin King
2020-03-30 17:21 ` David Miller
2020-03-30 17:52 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).