* [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option
@ 2020-12-10 9:20 Chao Yu
2020-12-10 17:23 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2020-12-10 9:20 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Chao Yu
Add a extra field compress_flag to get/set more compress option from/to
compressed inode.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
Daeho, Jaegeuk,
Could you please check whether we could add this new field to struct
f2fs_comp_option? so we can expand to allow user to query/config more
options of compressed inode via new ioctl.
It needs to consider before original patches goes to merge window, let
me know you have other concerns.
fs/f2fs/file.c | 1 +
include/uapi/linux/f2fs.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 16ea10f2bcf5..fbf06311c88d 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3965,6 +3965,7 @@ static int f2fs_ioc_get_compress_option(struct file *filp, unsigned long arg)
option.algorithm = F2FS_I(inode)->i_compress_algorithm;
option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
+ option.compress_flag = F2FS_I(inode)->i_compress_flag;
inode_unlock_shared(inode);
diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h
index 352a822d4370..2b9c4c99ceee 100644
--- a/include/uapi/linux/f2fs.h
+++ b/include/uapi/linux/f2fs.h
@@ -93,6 +93,7 @@ struct f2fs_sectrim_range {
struct f2fs_comp_option {
__u8 algorithm;
__u8 log_cluster_size;
+ __u16 compress_flag;
};
#endif /* _UAPI_LINUX_F2FS_H */
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option
2020-12-10 9:20 [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option Chao Yu
@ 2020-12-10 17:23 ` Jaegeuk Kim
2020-12-11 6:08 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2020-12-10 17:23 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, chao
On 12/10, Chao Yu wrote:
> Add a extra field compress_flag to get/set more compress option from/to
> compressed inode.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>
> Daeho, Jaegeuk,
>
> Could you please check whether we could add this new field to struct
> f2fs_comp_option? so we can expand to allow user to query/config more
> options of compressed inode via new ioctl.
>
> It needs to consider before original patches goes to merge window, let
> me know you have other concerns.
Chao, I think it'd hard to add this at time point, unless there's critical
info that we need to set very urgently.
>
> fs/f2fs/file.c | 1 +
> include/uapi/linux/f2fs.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 16ea10f2bcf5..fbf06311c88d 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3965,6 +3965,7 @@ static int f2fs_ioc_get_compress_option(struct file *filp, unsigned long arg)
>
> option.algorithm = F2FS_I(inode)->i_compress_algorithm;
> option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
> + option.compress_flag = F2FS_I(inode)->i_compress_flag;
>
> inode_unlock_shared(inode);
>
> diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h
> index 352a822d4370..2b9c4c99ceee 100644
> --- a/include/uapi/linux/f2fs.h
> +++ b/include/uapi/linux/f2fs.h
> @@ -93,6 +93,7 @@ struct f2fs_sectrim_range {
> struct f2fs_comp_option {
> __u8 algorithm;
> __u8 log_cluster_size;
> + __u16 compress_flag;
> };
>
> #endif /* _UAPI_LINUX_F2FS_H */
> --
> 2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option
2020-12-10 17:23 ` Jaegeuk Kim
@ 2020-12-11 6:08 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2020-12-11 6:08 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel, chao
On 2020/12/11 1:23, Jaegeuk Kim wrote:
> On 12/10, Chao Yu wrote:
>> Add a extra field compress_flag to get/set more compress option from/to
>> compressed inode.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>>
>> Daeho, Jaegeuk,
>>
>> Could you please check whether we could add this new field to struct
>> f2fs_comp_option? so we can expand to allow user to query/config more
>> options of compressed inode via new ioctl.
>>
>> It needs to consider before original patches goes to merge window, let
>> me know you have other concerns.
>
> Chao, I think it'd hard to add this at time point, unless there's critical
> info that we need to set very urgently.
Oops, so it needs extra ioctl interface to get/set newly added chksum and
compress_level configs...
Thanks,
>
>>
>> fs/f2fs/file.c | 1 +
>> include/uapi/linux/f2fs.h | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 16ea10f2bcf5..fbf06311c88d 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -3965,6 +3965,7 @@ static int f2fs_ioc_get_compress_option(struct file *filp, unsigned long arg)
>>
>> option.algorithm = F2FS_I(inode)->i_compress_algorithm;
>> option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
>> + option.compress_flag = F2FS_I(inode)->i_compress_flag;
>>
>> inode_unlock_shared(inode);
>>
>> diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h
>> index 352a822d4370..2b9c4c99ceee 100644
>> --- a/include/uapi/linux/f2fs.h
>> +++ b/include/uapi/linux/f2fs.h
>> @@ -93,6 +93,7 @@ struct f2fs_sectrim_range {
>> struct f2fs_comp_option {
>> __u8 algorithm;
>> __u8 log_cluster_size;
>> + __u16 compress_flag;
>> };
>>
>> #endif /* _UAPI_LINUX_F2FS_H */
>> --
>> 2.29.2
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-11 6:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 9:20 [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option Chao Yu
2020-12-10 17:23 ` Jaegeuk Kim
2020-12-11 6:08 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).