* [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD()
@ 2022-02-11 1:28 Cai Huoqing
2022-02-11 17:42 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2022-02-11 1:28 UTC (permalink / raw)
To: cai.huoqing
Cc: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb, linux-kernel
Replace "struct list_head head = LIST_HEAD_INIT(head)" with
"LIST_HEAD(head)" to simplify the code.
LIST_HEAD() helps to clean up the code "struct list_head vudc_devices =",
only to care about the variable 'vudc_devices'.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
v1->v2: update the changelog to explain why this change simplifies the code.
drivers/usb/usbip/vudc_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c
index 678faa82598c..d43252b77efd 100644
--- a/drivers/usb/usbip/vudc_main.c
+++ b/drivers/usb/usbip/vudc_main.c
@@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = {
},
};
-static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
+static LIST_HEAD(vudc_devices);
static int __init init(void)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD()
2022-02-11 1:28 [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD() Cai Huoqing
@ 2022-02-11 17:42 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2022-02-11 17:42 UTC (permalink / raw)
To: Cai Huoqing, Greg Kroah-Hartman
Cc: Valentina Manea, Shuah Khan, linux-usb, linux-kernel, Shuah Khan
On 2/10/22 6:28 PM, Cai Huoqing wrote:
> Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> "LIST_HEAD(head)" to simplify the code.
>
> LIST_HEAD() helps to clean up the code "struct list_head vudc_devices =",
> only to care about the variable 'vudc_devices'.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> v1->v2: update the changelog to explain why this change simplifies the code.
>
> drivers/usb/usbip/vudc_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c
> index 678faa82598c..d43252b77efd 100644
> --- a/drivers/usb/usbip/vudc_main.c
> +++ b/drivers/usb/usbip/vudc_main.c
> @@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = {
> },
> };
>
> -static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
> +static LIST_HEAD(vudc_devices);
>
> static int __init init(void)
> {
>
Hi Greg,
Please pick this up.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-11 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 1:28 [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD() Cai Huoqing
2022-02-11 17:42 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).