From: Boris Kolpackov <boris@codesynthesis.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Kalle Valo <kvalo@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Luca Coelho <luciano.coelho@intel.com>,
Mark Brown <broonie@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE'
Date: Wed, 25 Aug 2021 17:34:37 +0200 [thread overview]
Message-ID: <boris.20210825172545@codesynthesis.com> (raw)
In-Reply-To: <20210825041637.365171-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> Kconfig (syncconfig) generates include/generated/autoconf.h to make
> CONFIG options available to the pre-processor.
>
> The macros are suffixed with '_MODULE' for symbols with the value 'm'.
>
> Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1',
> but CONFIG_FOO_MODULE=y also results in the same define.
>
> fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the
> dependency is not properly tracked for symbols that end with '_MODULE'.
It seem to me the problem is in autoconf.h/fixdep, not in the Kconfig
language.
> This commit makes Kconfig error out if it finds a symbol suffixed with
> '_MODULE'.
I know you don't care, but I will voice my objection, for the record:
Kconfig is used by projects other than the Linux kernel and some of
them do not use the autoconf.h functionality. For such projects this
restriction seems arbitrary and potentially backwards-incompatible.
next prev parent reply other threads:[~2021-08-25 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 4:16 [PATCH] kconfig: forbid symbols that end with '_MODULE' Masahiro Yamada
2021-08-25 9:52 ` Mark Brown
2021-08-25 11:59 ` Péter Ujfalusi
2021-08-26 2:28 ` Masahiro Yamada
2021-09-01 7:07 ` Péter Ujfalusi
2021-08-25 15:34 ` Boris Kolpackov [this message]
2021-08-26 2:24 ` Masahiro Yamada
2021-08-26 12:16 ` Boris Kolpackov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=boris.20210825172545@codesynthesis.com \
--to=boris@codesynthesis.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).