From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Kalle Valo <kvalo@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Luca Coelho <luciano.coelho@intel.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE'
Date: Wed, 1 Sep 2021 10:07:57 +0300 [thread overview]
Message-ID: <d9e777dc-d274-92ee-4d77-711bfd553611@gmail.com> (raw)
In-Reply-To: <CAK7LNATDMzR1DnwwAcQFHaKZeGVYDZ1oDKL-QOe_7DaB_yByAA@mail.gmail.com>
On 26/08/2021 05:28, Masahiro Yamada wrote:
> On Wed, Aug 25, 2021 at 8:59 PM Péter Ujfalusi <peter.ujfalusi@gmail.com> wrote:
...
>>> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
>>> index 698d7bc84dcf..c56a5789056f 100644
>>> --- a/sound/soc/ti/Kconfig
>>> +++ b/sound/soc/ti/Kconfig
>>> @@ -211,7 +211,7 @@ config SND_SOC_DM365_VOICE_CODEC
>>> Say Y if you want to add support for SoC On-chip voice codec
>>> endchoice
>>>
>>> -config SND_SOC_DM365_VOICE_CODEC_MODULE
>>> +config SND_SOC_DM365_VOICE_CODEC_MODULAR
>>
>> This Kconfig option is only used to select the codecs needed for the
>> voice mode, I think it would be better to use something like
>>
>> SND_SOC_DM365_SELECT_VOICE_CODECS ?
>
> I do not have a strong opinion.
> I am fine with any name unless it ends with _MODULE.
>
>
> The sound subsystem maintainers and Arnd,
> author of 147162f575152db800 are CC'ed.
>
> If they suggest a better name, I'd be happy to adopt it.
>
Can you resend (a separate patch would be even better) with
SND_SOC_DM365_SELECT_VOICE_CODECS
for sound/soc/ti/Kconfig ?
Thank you,
Péter
next prev parent reply other threads:[~2021-09-01 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 4:16 [PATCH] kconfig: forbid symbols that end with '_MODULE' Masahiro Yamada
2021-08-25 9:52 ` Mark Brown
2021-08-25 11:59 ` Péter Ujfalusi
2021-08-26 2:28 ` Masahiro Yamada
2021-09-01 7:07 ` Péter Ujfalusi [this message]
2021-08-25 15:34 ` Boris Kolpackov
2021-08-26 2:24 ` Masahiro Yamada
2021-08-26 12:16 ` Boris Kolpackov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e777dc-d274-92ee-4d77-711bfd553611@gmail.com \
--to=peter.ujfalusi@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).