* [PATCH linux-next] module: remove duplicate include in interrupt.c
@ 2021-08-16 11:29 cgel.zte
2021-08-17 11:56 ` Zenghui Yu
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-08-16 11:29 UTC (permalink / raw)
To: linux; +Cc: yang.guang5, linux-arm-kernel, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
'asm/interrupt.h' included in 'interrupt.c' is duplicated.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
arch/arm/mach-sa1100/hackkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
index 3085f1c2e586..3fe34ee7c0ab 100644
--- a/arch/arm/mach-sa1100/hackkit.c
+++ b/arch/arm/mach-sa1100/hackkit.c
@@ -18,7 +18,6 @@
#include <linux/serial_core.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
-#include <linux/tty.h>
#include <linux/gpio.h>
#include <linux/leds.h>
#include <linux/platform_device.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] module: remove duplicate include in interrupt.c
2021-08-16 11:29 [PATCH linux-next] module: remove duplicate include in interrupt.c cgel.zte
@ 2021-08-17 11:56 ` Zenghui Yu
0 siblings, 0 replies; 4+ messages in thread
From: Zenghui Yu @ 2021-08-17 11:56 UTC (permalink / raw)
To: cgel.zte
Cc: linux, yang.guang5, linux-arm-kernel, linux-kernel, Lv Ruyi, Zeal Robot
On 2021/8/16 19:29, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> 'asm/interrupt.h' included in 'interrupt.c' is duplicated.
Sorry but this obviously doesn't match with the change you've made.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> arch/arm/mach-sa1100/hackkit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
> index 3085f1c2e586..3fe34ee7c0ab 100644
> --- a/arch/arm/mach-sa1100/hackkit.c
> +++ b/arch/arm/mach-sa1100/hackkit.c
> @@ -18,7 +18,6 @@
> #include <linux/serial_core.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> -#include <linux/tty.h>
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/platform_device.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] module: remove duplicate include in interrupt.c
2021-08-16 11:34 cgel.zte
@ 2021-08-16 11:57 ` Christophe Leroy
0 siblings, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2021-08-16 11:57 UTC (permalink / raw)
To: cgel.zte, mpe
Cc: benh, paulus, npiggin, linuxppc-dev, linux-kernel, Lv Ruyi, Zeal Robot
Le 16/08/2021 à 13:34, cgel.zte@gmail.com a écrit :
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> 'asm/interrupt.h' included in 'interrupt.c' is duplicated.
This patch has been submitted at least half a dozen of times already.
You should maintain alphabetic order in the include list.
But please don't post it again, we have it in the pipe already, see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1624329437-84730-1-git-send-email-jiapeng.chong@linux.alibaba.com/
Next time please check at https://patchwork.ozlabs.org/project/linuxppc-dev/list/ before submitting
a new patch.
Thanks
Christophe
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> arch/powerpc/kernel/interrupt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
> index 21bbd615ca41..8a936515e4e4 100644
> --- a/arch/powerpc/kernel/interrupt.c
> +++ b/arch/powerpc/kernel/interrupt.c
> @@ -10,7 +10,6 @@
> #include <asm/cputime.h>
> #include <asm/interrupt.h>
> #include <asm/hw_irq.h>
> -#include <asm/interrupt.h>
> #include <asm/kprobes.h>
> #include <asm/paca.h>
> #include <asm/ptrace.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH linux-next] module: remove duplicate include in interrupt.c
@ 2021-08-16 11:34 cgel.zte
2021-08-16 11:57 ` Christophe Leroy
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-08-16 11:34 UTC (permalink / raw)
To: mpe
Cc: benh, paulus, npiggin, christophe.leroy, linuxppc-dev,
linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
'asm/interrupt.h' included in 'interrupt.c' is duplicated.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
arch/powerpc/kernel/interrupt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index 21bbd615ca41..8a936515e4e4 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -10,7 +10,6 @@
#include <asm/cputime.h>
#include <asm/interrupt.h>
#include <asm/hw_irq.h>
-#include <asm/interrupt.h>
#include <asm/kprobes.h>
#include <asm/paca.h>
#include <asm/ptrace.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-17 11:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 11:29 [PATCH linux-next] module: remove duplicate include in interrupt.c cgel.zte
2021-08-17 11:56 ` Zenghui Yu
2021-08-16 11:34 cgel.zte
2021-08-16 11:57 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).