* [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.
@ 2019-04-04 17:25 Michal Suchanek
2019-04-05 7:07 ` Stefan Wahren
2019-04-26 11:23 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Michal Suchanek @ 2019-04-04 17:25 UTC (permalink / raw)
To: bcm-kernel-feedback-list, dmaengine, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Cc: Michal Suchanek, Vinod Koul, Dan Williams, Eric Anholt,
Stefan Wahren, Florian Fainelli, Ray Jui, Scott Branden
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
drivers/dma/bcm2835-dma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index ec8a291d62ba..e38b19dd2895 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
- dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.
2019-04-04 17:25 [PATCH] dmaengine: bcm2835: Drop duplicate capability setting Michal Suchanek
@ 2019-04-05 7:07 ` Stefan Wahren
2019-04-26 11:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2019-04-05 7:07 UTC (permalink / raw)
To: Michal Suchanek, bcm-kernel-feedback-list, dmaengine,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
Cc: Vinod Koul, Dan Williams, Eric Anholt, Florian Fainelli, Ray Jui,
Scott Branden
Am 04.04.19 um 19:25 schrieb Michal Suchanek:
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Except of the point there is no commit log:
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/dma/bcm2835-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index ec8a291d62ba..e38b19dd2895 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
> dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
> - dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
> od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
> od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.
2019-04-04 17:25 [PATCH] dmaengine: bcm2835: Drop duplicate capability setting Michal Suchanek
2019-04-05 7:07 ` Stefan Wahren
@ 2019-04-26 11:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-04-26 11:23 UTC (permalink / raw)
To: Michal Suchanek
Cc: bcm-kernel-feedback-list, dmaengine, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, Dan Williams, Eric Anholt,
Stefan Wahren, Florian Fainelli, Ray Jui, Scott Branden
On 04-04-19, 19:25, Michal Suchanek wrote:
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> drivers/dma/bcm2835-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index ec8a291d62ba..e38b19dd2895 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
> dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
> - dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
> od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
> od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-26 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 17:25 [PATCH] dmaengine: bcm2835: Drop duplicate capability setting Michal Suchanek
2019-04-05 7:07 ` Stefan Wahren
2019-04-26 11:23 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).