* [PATCH] mtd: nand: xway: fix build failure
@ 2016-12-23 8:17 Sudip Mukherjee
2016-12-23 9:07 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2016-12-23 8:17 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen
Cc: linux-kernel, linux-mtd, Sudip Mukherjee
The build of mips xway_defconfig was failing with the error:
drivers/mtd/nand/xway_nand.c:235:1: warning:
data definition has no type or storage class
MODULE_DEVICE_TABLE(of, xway_nand_match);
^~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/xway_nand.c:235:1: error:
type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
[-Werror=implicit-int]
It missed to include the header file.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
Build log of next-20161223 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
This error will be fixed but it will now uncover the next error as the
build goes on.
drivers/mtd/nand/xway_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
index 1f2948c..00168d6 100644
--- a/drivers/mtd/nand/xway_nand.c
+++ b/drivers/mtd/nand/xway_nand.c
@@ -7,6 +7,7 @@
* Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
*/
+#include <linux/module.h>
#include <linux/mtd/nand.h>
#include <linux/of_gpio.h>
#include <linux/of_platform.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: xway: fix build failure
2016-12-23 8:17 [PATCH] mtd: nand: xway: fix build failure Sudip Mukherjee
@ 2016-12-23 9:07 ` Marek Vasut
2016-12-29 16:28 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2016-12-23 9:07 UTC (permalink / raw)
To: Sudip Mukherjee, Boris Brezillon, Richard Weinberger,
David Woodhouse, Brian Norris, Cyrille Pitchen
Cc: linux-kernel, linux-mtd
On 12/23/2016 09:17 AM, Sudip Mukherjee wrote:
> The build of mips xway_defconfig was failing with the error:
>
> drivers/mtd/nand/xway_nand.c:235:1: warning:
> data definition has no type or storage class
> MODULE_DEVICE_TABLE(of, xway_nand_match);
> ^~~~~~~~~~~~~~~~~~~
> drivers/mtd/nand/xway_nand.c:235:1: error:
> type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> [-Werror=implicit-int]
>
> It missed to include the header file.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Marek Vasut <marex@denx.de>
> ---
>
> Build log of next-20161223 is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
>
> This error will be fixed but it will now uncover the next error as the
> build goes on.
>
> drivers/mtd/nand/xway_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> index 1f2948c..00168d6 100644
> --- a/drivers/mtd/nand/xway_nand.c
> +++ b/drivers/mtd/nand/xway_nand.c
> @@ -7,6 +7,7 @@
> * Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
> */
>
> +#include <linux/module.h>
> #include <linux/mtd/nand.h>
> #include <linux/of_gpio.h>
> #include <linux/of_platform.h>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: xway: fix build failure
2016-12-23 9:07 ` Marek Vasut
@ 2016-12-29 16:28 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-12-29 16:28 UTC (permalink / raw)
To: Marek Vasut, Sudip Mukherjee
Cc: Richard Weinberger, David Woodhouse, Brian Norris,
Cyrille Pitchen, linux-kernel, linux-mtd, Hauke Mehrtens
+Hauke
Sudip, Marek,
On Fri, 23 Dec 2016 10:07:23 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:
> On 12/23/2016 09:17 AM, Sudip Mukherjee wrote:
> > The build of mips xway_defconfig was failing with the error:
> >
> > drivers/mtd/nand/xway_nand.c:235:1: warning:
> > data definition has no type or storage class
> > MODULE_DEVICE_TABLE(of, xway_nand_match);
> > ^~~~~~~~~~~~~~~~~~~
> > drivers/mtd/nand/xway_nand.c:235:1: error:
> > type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > [-Werror=implicit-int]
> >
> > It missed to include the header file.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Acked-by: Marek Vasut <marex@denx.de>
Nack. Hauke already sent a fix for that one, and I'm about to queue it
in my fixes-for-4.10 branch.
Marek, if you want to ack these patches, please review [1] and [2].
Thanks,
Boris
[1]https://patchwork.ozlabs.org/patch/702880/
[2]https://patchwork.ozlabs.org/patch/702879/
>
> > ---
> >
> > Build log of next-20161223 is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
> >
> > This error will be fixed but it will now uncover the next error as the
> > build goes on.
> >
> > drivers/mtd/nand/xway_nand.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> > index 1f2948c..00168d6 100644
> > --- a/drivers/mtd/nand/xway_nand.c
> > +++ b/drivers/mtd/nand/xway_nand.c
> > @@ -7,6 +7,7 @@
> > * Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
> > */
> >
> > +#include <linux/module.h>
> > #include <linux/mtd/nand.h>
> > #include <linux/of_gpio.h>
> > #include <linux/of_platform.h>
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-29 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-23 8:17 [PATCH] mtd: nand: xway: fix build failure Sudip Mukherjee
2016-12-23 9:07 ` Marek Vasut
2016-12-29 16:28 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).