From: Yannick FERTRE <yannick.fertre@st.com>
To: Alexandre TORGUE <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Benjamin GAIGNARD <benjamin.gaignard@st.com>,
Philippe CORNU <philippe.cornu@st.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
Date: Fri, 4 Oct 2019 13:21:04 +0000 [thread overview]
Message-ID: <c0d6de33-38fa-b55e-20cb-e5b680a35dfb@st.com> (raw)
In-Reply-To: <09ad1310-ebc5-7a41-7af6-cdef79f20802@st.com>
Hi Alex,
ok, i'll push only the dt patch link to the last version of driver
touchscreen on display board MB1407.
BR
Yannick Fertré
On 10/3/19 12:34 PM, Alexandre Torgue wrote:
> Hi Yannick
>
> On 9/30/19 4:45 PM, Yannick Fertré wrote:
>> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
>> This device supports 2 different addresses (0x2a and 0x38)
>> depending on the display board version (MB1407).
>>
>> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
>> ---
>> arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> index 20ea601..527bb75 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> @@ -61,6 +61,29 @@
>> };
>> };
>> +&i2c1 {
>> + touchscreen@2a {
>> + compatible = "focaltech,ft6236";
>> + reg = <0x2a>;
>> + interrupts = <2 2>;
>> + interrupt-parent = <&gpiof>;
>> + interrupt-controller;
>> + touchscreen-size-x = <480>;
>> + touchscreen-size-y = <800>;
>> + status = "okay";
>> + };
>> + touchscreen@38 {
>> + compatible = "focaltech,ft6236";
>> + reg = <0x38>;
>> + interrupts = <2 2>;
>> + interrupt-parent = <&gpiof>;
>> + interrupt-controller;
>> + touchscreen-size-x = <480>;
>> + touchscreen-size-y = <800>;
>> + status = "okay";
>> + };
>> +};
>
> I'm not confident by this duplication. We should only support the
> latest revision of the MB1407. I understand the need but my fear is to
> duplicate this node each time we have a new revision (and imagine if
> we do that for all i2c devices).
>
> regards
> alex
>
>
>> <dc {
>> status = "okay";
next prev parent reply other threads:[~2019-10-04 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:45 [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board Yannick Fertré
2019-10-03 10:34 ` Alexandre Torgue
2019-10-04 13:21 ` Yannick FERTRE [this message]
2019-10-04 13:17 Yannick Fertré
2019-10-04 14:05 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d6de33-38fa-b55e-20cb-e5b680a35dfb@st.com \
--to=yannick.fertre@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).