* [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
@ 2019-09-30 14:45 Yannick Fertré
2019-10-03 10:34 ` Alexandre Torgue
0 siblings, 1 reply; 5+ messages in thread
From: Yannick Fertré @ 2019-09-30 14:45 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland,
linux-stm32, linux-arm-kernel, devicetree, linux-kernel,
Benjamin Gaignard, Yannick Fertré,
Philippe Cornu, Fabrice Gasnier
Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
This device supports 2 different addresses (0x2a and 0x38)
depending on the display board version (MB1407).
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
index 20ea601..527bb75 100644
--- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
@@ -61,6 +61,29 @@
};
};
+&i2c1 {
+ touchscreen@2a {
+ compatible = "focaltech,ft6236";
+ reg = <0x2a>;
+ interrupts = <2 2>;
+ interrupt-parent = <&gpiof>;
+ interrupt-controller;
+ touchscreen-size-x = <480>;
+ touchscreen-size-y = <800>;
+ status = "okay";
+ };
+ touchscreen@38 {
+ compatible = "focaltech,ft6236";
+ reg = <0x38>;
+ interrupts = <2 2>;
+ interrupt-parent = <&gpiof>;
+ interrupt-controller;
+ touchscreen-size-x = <480>;
+ touchscreen-size-y = <800>;
+ status = "okay";
+ };
+};
+
<dc {
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
2019-09-30 14:45 [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board Yannick Fertré
@ 2019-10-03 10:34 ` Alexandre Torgue
2019-10-04 13:21 ` Yannick FERTRE
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Torgue @ 2019-10-03 10:34 UTC (permalink / raw)
To: Yannick Fertré,
Maxime Coquelin, Rob Herring, Mark Rutland, linux-stm32,
linux-arm-kernel, devicetree, linux-kernel, Benjamin Gaignard,
Philippe Cornu, Fabrice Gasnier
Hi Yannick
On 9/30/19 4:45 PM, Yannick Fertré wrote:
> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
> This device supports 2 different addresses (0x2a and 0x38)
> depending on the display board version (MB1407).
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> index 20ea601..527bb75 100644
> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> @@ -61,6 +61,29 @@
> };
> };
>
> +&i2c1 {
> + touchscreen@2a {
> + compatible = "focaltech,ft6236";
> + reg = <0x2a>;
> + interrupts = <2 2>;
> + interrupt-parent = <&gpiof>;
> + interrupt-controller;
> + touchscreen-size-x = <480>;
> + touchscreen-size-y = <800>;
> + status = "okay";
> + };
> + touchscreen@38 {
> + compatible = "focaltech,ft6236";
> + reg = <0x38>;
> + interrupts = <2 2>;
> + interrupt-parent = <&gpiof>;
> + interrupt-controller;
> + touchscreen-size-x = <480>;
> + touchscreen-size-y = <800>;
> + status = "okay";
> + };
> +};
I'm not confident by this duplication. We should only support the latest
revision of the MB1407. I understand the need but my fear is to
duplicate this node each time we have a new revision (and imagine if we
do that for all i2c devices).
regards
alex
> <dc {
> status = "okay";
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
2019-10-03 10:34 ` Alexandre Torgue
@ 2019-10-04 13:21 ` Yannick FERTRE
0 siblings, 0 replies; 5+ messages in thread
From: Yannick FERTRE @ 2019-10-04 13:21 UTC (permalink / raw)
To: Alexandre TORGUE, Maxime Coquelin, Rob Herring, Mark Rutland,
linux-stm32, linux-arm-kernel, devicetree, linux-kernel,
Benjamin GAIGNARD, Philippe CORNU, Fabrice GASNIER
Hi Alex,
ok, i'll push only the dt patch link to the last version of driver
touchscreen on display board MB1407.
BR
Yannick Fertré
On 10/3/19 12:34 PM, Alexandre Torgue wrote:
> Hi Yannick
>
> On 9/30/19 4:45 PM, Yannick Fertré wrote:
>> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
>> This device supports 2 different addresses (0x2a and 0x38)
>> depending on the display board version (MB1407).
>>
>> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
>> ---
>> arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> index 20ea601..527bb75 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> @@ -61,6 +61,29 @@
>> };
>> };
>> +&i2c1 {
>> + touchscreen@2a {
>> + compatible = "focaltech,ft6236";
>> + reg = <0x2a>;
>> + interrupts = <2 2>;
>> + interrupt-parent = <&gpiof>;
>> + interrupt-controller;
>> + touchscreen-size-x = <480>;
>> + touchscreen-size-y = <800>;
>> + status = "okay";
>> + };
>> + touchscreen@38 {
>> + compatible = "focaltech,ft6236";
>> + reg = <0x38>;
>> + interrupts = <2 2>;
>> + interrupt-parent = <&gpiof>;
>> + interrupt-controller;
>> + touchscreen-size-x = <480>;
>> + touchscreen-size-y = <800>;
>> + status = "okay";
>> + };
>> +};
>
> I'm not confident by this duplication. We should only support the
> latest revision of the MB1407. I understand the need but my fear is to
> duplicate this node each time we have a new revision (and imagine if
> we do that for all i2c devices).
>
> regards
> alex
>
>
>> <dc {
>> status = "okay";
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
2019-10-04 13:17 Yannick Fertré
@ 2019-10-04 14:05 ` Alexandre Torgue
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Torgue @ 2019-10-04 14:05 UTC (permalink / raw)
To: Yannick Fertré,
Maxime Coquelin, Rob Herring, Mark Rutland, linux-stm32,
linux-arm-kernel, devicetree, linux-kernel, Benjamin Gaignard,
Philippe Cornu, Fabrice Gasnier
Hi yannick
On 10/4/19 3:17 PM, Yannick Fertré wrote:
> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> arch/arm/boot/dts/stm32mp157c-dk2.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> index 20ea601..d44a7c6 100644
> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> @@ -61,6 +61,19 @@
> };
> };
>
> +&i2c1 {
> + touchscreen@38 {
> + compatible = "focaltech,ft6236";
> + reg = <0x38>;
> + interrupts = <2 2>;
> + interrupt-parent = <&gpiof>;
> + interrupt-controller;
> + touchscreen-size-x = <480>;
> + touchscreen-size-y = <800>;
> + status = "okay";
> + };
> +};
> +
> <dc {
> status = "okay";
>
>
For the next time, please don't forget to add "PATCH-v2" as it is a
second version of this patch.
Applied on stm32-next.
Thanks.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board
@ 2019-10-04 13:17 Yannick Fertré
2019-10-04 14:05 ` Alexandre Torgue
0 siblings, 1 reply; 5+ messages in thread
From: Yannick Fertré @ 2019-10-04 13:17 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland,
linux-stm32, linux-arm-kernel, devicetree, linux-kernel,
Benjamin Gaignard, Yannick Fertre, Philippe Cornu,
Fabrice Gasnier
Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
arch/arm/boot/dts/stm32mp157c-dk2.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
index 20ea601..d44a7c6 100644
--- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
@@ -61,6 +61,19 @@
};
};
+&i2c1 {
+ touchscreen@38 {
+ compatible = "focaltech,ft6236";
+ reg = <0x38>;
+ interrupts = <2 2>;
+ interrupt-parent = <&gpiof>;
+ interrupt-controller;
+ touchscreen-size-x = <480>;
+ touchscreen-size-y = <800>;
+ status = "okay";
+ };
+};
+
<dc {
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-04 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 14:45 [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board Yannick Fertré
2019-10-03 10:34 ` Alexandre Torgue
2019-10-04 13:21 ` Yannick FERTRE
2019-10-04 13:17 Yannick Fertré
2019-10-04 14:05 ` Alexandre Torgue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).