From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org, Dan Robertson <danlrobertson89@gmail.com>
Subject: Re: [PATCH] scripts: gdb: redefine MS_RDONLY
Date: Fri, 15 Feb 2019 20:28:54 +0000 [thread overview]
Message-ID: <c20250bb-cd61-eb07-c440-866ec45010b8@ideasonboard.com> (raw)
In-Reply-To: <20190215112938.25574-1-felipe.balbi@linux.intel.com>
Hi Felipe,
Thank you for the patch,
On 15/02/2019 11:29, Felipe Balbi wrote:
> Since commit e262e32d6bde0f77fb0c95d977482fc872c51996 "vfs: Suppress
> MS_* flag defs within the kernel unless explicitly enabled", the
> generated gdb scripts can't be used anymore. That commit moved the
> definition of MS_* flags but forgot to update gdb scripts to use the
> new location. This patch includes <uapi/linux/mount.h> to
> constants.py.in so gdb scripts are functional again.
>
> Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled"
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
> scripts/gdb/linux/constants.py.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 7aad82406422..c2a93805d911 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -13,6 +13,7 @@
> */
>
> #include <linux/fs.h>
Do we still need linux/fs.h?
> +#include <uapi/linux/mount.h>
Perhaps this should go at the end to maintain alphabetical ordering?
> #include <linux/mount.h>
> #include <linux/of_fdt.h>
>
We can see from Dan's patch - that the comment above the value
definitions also needs to be updated...
Felipe, you won the patch race - how would you like to handle this? Will
you resubmit with changes? or should we just add the missing Fixes: tag
to Dan's patch?
--
Regards
--
Kieran
next prev parent reply other threads:[~2019-02-15 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 11:29 [PATCH] scripts: gdb: redefine MS_RDONLY Felipe Balbi
2019-02-15 20:28 ` Kieran Bingham [this message]
2019-02-18 7:17 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20250bb-cd61-eb07-c440-866ec45010b8@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=danlrobertson89@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).