* [PATCH] scripts: gdb: redefine MS_RDONLY
@ 2019-02-15 11:29 Felipe Balbi
2019-02-15 20:28 ` Kieran Bingham
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2019-02-15 11:29 UTC (permalink / raw)
To: Jan Kiszka, Kieran Bingham; +Cc: linux-kernel, Felipe Balbi
Since commit e262e32d6bde0f77fb0c95d977482fc872c51996 "vfs: Suppress
MS_* flag defs within the kernel unless explicitly enabled", the
generated gdb scripts can't be used anymore. That commit moved the
definition of MS_* flags but forgot to update gdb scripts to use the
new location. This patch includes <uapi/linux/mount.h> to
constants.py.in so gdb scripts are functional again.
Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled"
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---
scripts/gdb/linux/constants.py.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index 7aad82406422..c2a93805d911 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -13,6 +13,7 @@
*/
#include <linux/fs.h>
+#include <uapi/linux/mount.h>
#include <linux/mount.h>
#include <linux/of_fdt.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts: gdb: redefine MS_RDONLY
2019-02-15 11:29 [PATCH] scripts: gdb: redefine MS_RDONLY Felipe Balbi
@ 2019-02-15 20:28 ` Kieran Bingham
2019-02-18 7:17 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Bingham @ 2019-02-15 20:28 UTC (permalink / raw)
To: Felipe Balbi, Jan Kiszka; +Cc: linux-kernel, Dan Robertson
Hi Felipe,
Thank you for the patch,
On 15/02/2019 11:29, Felipe Balbi wrote:
> Since commit e262e32d6bde0f77fb0c95d977482fc872c51996 "vfs: Suppress
> MS_* flag defs within the kernel unless explicitly enabled", the
> generated gdb scripts can't be used anymore. That commit moved the
> definition of MS_* flags but forgot to update gdb scripts to use the
> new location. This patch includes <uapi/linux/mount.h> to
> constants.py.in so gdb scripts are functional again.
>
> Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled"
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
> scripts/gdb/linux/constants.py.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 7aad82406422..c2a93805d911 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -13,6 +13,7 @@
> */
>
> #include <linux/fs.h>
Do we still need linux/fs.h?
> +#include <uapi/linux/mount.h>
Perhaps this should go at the end to maintain alphabetical ordering?
> #include <linux/mount.h>
> #include <linux/of_fdt.h>
>
We can see from Dan's patch - that the comment above the value
definitions also needs to be updated...
Felipe, you won the patch race - how would you like to handle this? Will
you resubmit with changes? or should we just add the missing Fixes: tag
to Dan's patch?
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts: gdb: redefine MS_RDONLY
2019-02-15 20:28 ` Kieran Bingham
@ 2019-02-18 7:17 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2019-02-18 7:17 UTC (permalink / raw)
To: kieran.bingham, Jan Kiszka; +Cc: linux-kernel, Dan Robertson
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
Hi,
Kieran Bingham <kieran.bingham@ideasonboard.com> writes:
> Hi Felipe,
>
> Thank you for the patch,
>
> On 15/02/2019 11:29, Felipe Balbi wrote:
>> Since commit e262e32d6bde0f77fb0c95d977482fc872c51996 "vfs: Suppress
>> MS_* flag defs within the kernel unless explicitly enabled", the
>> generated gdb scripts can't be used anymore. That commit moved the
>> definition of MS_* flags but forgot to update gdb scripts to use the
>> new location. This patch includes <uapi/linux/mount.h> to
>> constants.py.in so gdb scripts are functional again.
>>
>> Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled"
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> ---
>> scripts/gdb/linux/constants.py.in | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
>> index 7aad82406422..c2a93805d911 100644
>> --- a/scripts/gdb/linux/constants.py.in
>> +++ b/scripts/gdb/linux/constants.py.in
>> @@ -13,6 +13,7 @@
>> */
>>
>> #include <linux/fs.h>
>
> Do we still need linux/fs.h?
don't know enough about the tool to judge that. Just added the minimal
change to get it working again.
>> +#include <uapi/linux/mount.h>
>
> Perhaps this should go at the end to maintain alphabetical ordering?
>
>> #include <linux/mount.h>
>> #include <linux/of_fdt.h>
>>
>
> We can see from Dan's patch - that the comment above the value
> definitions also needs to be updated...
>
> Felipe, you won the patch race - how would you like to handle this? Will
> you resubmit with changes? or should we just add the missing Fixes: tag
> to Dan's patch?
I don't mind either way, as long as the GDB scripts are working upstream :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-18 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 11:29 [PATCH] scripts: gdb: redefine MS_RDONLY Felipe Balbi
2019-02-15 20:28 ` Kieran Bingham
2019-02-18 7:17 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).