From: Vladimir Zapolskiy <vz@mleia.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"kernel test robot" <lkp@intel.com>,
kbuild-all@lists.01.org, "Krzysztof Kozlowski" <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: fix semicolon.cocci warnings
Date: Fri, 29 Jan 2021 18:51:54 +0200 [thread overview]
Message-ID: <c2152a64-d4ae-f18d-9af7-b80b12474b00@mleia.com> (raw)
In-Reply-To: <20210128205716.j2afd32lcxh2l323@pengutronix.de>
On 1/28/21 10:57 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")
>
> This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.
>
> The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
> driver")
Right, thank you for the correction, Uwe.
Since the patch has been composed by the robot, it has to be fixed
in the first place.
And regarding this particular change and in general fixes to this type
of issues detected by the robot, I don't think that it earns a Fixes tag.
>> CC: Krzysztof Kozlowski <krzk@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
--
Best wishes,
Vladimir
prev parent reply other threads:[~2021-01-29 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 13:45 drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon kernel test robot
2021-01-28 13:45 ` [PATCH] pwm: fix semicolon.cocci warnings kernel test robot
2021-01-28 15:01 ` Vladimir Zapolskiy
2021-01-28 20:57 ` Uwe Kleine-König
2021-01-29 16:51 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2152a64-d4ae-f18d-9af7-b80b12474b00@mleia.com \
--to=vz@mleia.com \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).