From: Bart Van Assche <bvanassche@acm.org>
To: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@lst.de>
Cc: Avihai Horon <avihaih@nvidia.com>,
Adit Ranadive <aditr@vmware.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Ariel Elior <aelior@marvell.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Christoph Hellwig <hch@lst.de>,
Chuck Lever <chuck.lever@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Faisal Latif <faisal.latif@intel.com>,
Jack Wang <jinpu.wang@ionos.com>,
Jakub Kicinski <kuba@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Jens Axboe <axboe@fb.com>, Karsten Graul <kgraul@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>, Lijun Ou <oulijun@huawei.com>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
Max Gurtovoy <maxg@mellanox.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
netdev@vger.kernel.org, Potnuri Bharat Teja <bharat@chelsio.com>,
rds-devel@oss.oracle.com, Sagi Grimberg <sagi@grimberg.me>,
samba-technical@lists.samba.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Steve French <sfrench@samba.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()
Date: Mon, 5 Apr 2021 08:27:16 -0700 [thread overview]
Message-ID: <c21edd64-396c-4c7c-86f8-79045321a528@acm.org> (raw)
In-Reply-To: <20210405052404.213889-2-leon@kernel.org>
On 4/4/21 10:23 PM, Leon Romanovsky wrote:
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index bed4cfe50554..59138174affa 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -2444,10 +2444,10 @@ struct ib_device_ops {
> struct ib_udata *udata);
> int (*dereg_mr)(struct ib_mr *mr, struct ib_udata *udata);
> struct ib_mr *(*alloc_mr)(struct ib_pd *pd, enum ib_mr_type mr_type,
> - u32 max_num_sg);
> + u32 max_num_sg, u32 access);
> struct ib_mr *(*alloc_mr_integrity)(struct ib_pd *pd,
> u32 max_num_data_sg,
> - u32 max_num_meta_sg);
> + u32 max_num_meta_sg, u32 access);
> int (*advise_mr)(struct ib_pd *pd,
> enum ib_uverbs_advise_mr_advice advice, u32 flags,
> struct ib_sge *sg_list, u32 num_sge,
> @@ -4142,11 +4142,10 @@ static inline int ib_dereg_mr(struct ib_mr *mr)
> }
>
> struct ib_mr *ib_alloc_mr(struct ib_pd *pd, enum ib_mr_type mr_type,
> - u32 max_num_sg);
> + u32 max_num_sg, u32 access);
>
> -struct ib_mr *ib_alloc_mr_integrity(struct ib_pd *pd,
> - u32 max_num_data_sg,
> - u32 max_num_meta_sg);
> +struct ib_mr *ib_alloc_mr_integrity(struct ib_pd *pd, u32 max_num_data_sg,
> + u32 max_num_meta_sg, u32 access);
>
> /**
> * ib_update_fast_reg_key - updates the key portion of the fast_reg MR
> diff --git a/include/rdma/mr_pool.h b/include/rdma/mr_pool.h
> index e77123bcb43b..2a0ee791037d 100644
> --- a/include/rdma/mr_pool.h
> +++ b/include/rdma/mr_pool.h
> @@ -11,7 +11,8 @@ struct ib_mr *ib_mr_pool_get(struct ib_qp *qp, struct list_head *list);
> void ib_mr_pool_put(struct ib_qp *qp, struct list_head *list, struct ib_mr *mr);
>
> int ib_mr_pool_init(struct ib_qp *qp, struct list_head *list, int nr,
> - enum ib_mr_type type, u32 max_num_sg, u32 max_num_meta_sg);
> + enum ib_mr_type type, u32 max_num_sg, u32 max_num_meta_sg,
> + u32 access);
> void ib_mr_pool_destroy(struct ib_qp *qp, struct list_head *list);
>
> #endif /* _RDMA_MR_POOL_H */
Does the new 'access' argument only control whether or not PCIe relaxed
ordering is enabled? It seems wrong to me to make enabling of PCIe
relaxed ordering configurable. I think this mechanism should be enabled
unconditionally if the HCA supports it.
Thanks,
Bart.
next prev parent reply other threads:[~2021-04-05 15:27 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 5:23 [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs Leon Romanovsky
2021-04-05 5:23 ` [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init() Leon Romanovsky
2021-04-05 13:46 ` Christoph Hellwig
2021-04-06 5:24 ` Leon Romanovsky
2021-04-05 15:27 ` Bart Van Assche [this message]
2021-04-06 5:23 ` Leon Romanovsky
2021-04-06 5:27 ` Christoph Hellwig
2021-04-06 5:58 ` Leon Romanovsky
2021-04-06 12:13 ` Jason Gunthorpe
2021-04-06 12:30 ` Christoph Hellwig
2021-04-06 14:04 ` Jason Gunthorpe
2021-04-06 14:15 ` Christoph Hellwig
2021-04-06 14:40 ` Jason Gunthorpe
2021-04-06 14:54 ` Christoph Hellwig
2021-04-06 15:03 ` Christoph Hellwig
2021-04-07 18:28 ` Jason Gunthorpe
2021-04-05 5:23 ` [PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd() Leon Romanovsky
2021-04-05 18:01 ` Tom Talpey
2021-04-05 20:40 ` Adit Ranadive
2021-04-06 6:28 ` Leon Romanovsky
2021-04-05 5:23 ` [PATCH rdma-next 03/10] RDMA/iser: Enable Relaxed Ordering Leon Romanovsky
2021-04-05 5:23 ` [PATCH rdma-next 04/10] RDMA/rtrs: " Leon Romanovsky
2021-04-05 5:23 ` [PATCH rdma-next 05/10] RDMA/srp: " Leon Romanovsky
2021-04-05 5:24 ` [PATCH rdma-next 06/10] nvme-rdma: " Leon Romanovsky
2021-04-05 5:24 ` [PATCH rdma-next 07/10] cifs: smbd: " Leon Romanovsky
2021-04-05 5:24 ` [PATCH rdma-next 08/10] net/rds: " Leon Romanovsky
2021-04-05 5:24 ` [PATCH rdma-next 09/10] net/smc: " Leon Romanovsky
2021-04-05 5:24 ` [PATCH rdma-next 10/10] xprtrdma: " Leon Romanovsky
2021-04-05 13:41 ` [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs Christoph Hellwig
2021-04-05 14:08 ` Leon Romanovsky
2021-04-05 16:11 ` Santosh Shilimkar
2021-04-05 17:54 ` Tom Talpey
2021-04-05 20:07 ` Jason Gunthorpe
2021-04-05 23:42 ` Chuck Lever III
2021-04-05 23:50 ` Keith Busch
2021-04-06 5:12 ` Leon Romanovsky
2021-04-06 11:49 ` Jason Gunthorpe
2021-04-09 14:26 ` Tom Talpey
2021-04-09 14:45 ` Chuck Lever III
2021-04-09 15:32 ` Tom Talpey
2021-04-09 16:27 ` Haakon Bugge
2021-04-09 17:49 ` Tom Talpey
2021-04-10 13:30 ` David Laight
2021-04-12 18:32 ` Haakon Bugge
2021-04-12 20:20 ` Tom Talpey
2021-04-12 22:48 ` Jason Gunthorpe
2021-04-14 14:16 ` Tom Talpey
2021-04-14 14:41 ` David Laight
2021-04-14 14:49 ` Jason Gunthorpe
2021-04-14 14:44 ` Jason Gunthorpe
2021-04-09 16:40 ` Jason Gunthorpe
2021-04-09 17:44 ` Tom Talpey
2021-04-06 2:37 ` Honggang LI
2021-04-06 5:09 ` Leon Romanovsky
2021-04-06 11:53 ` Jason Gunthorpe
2021-04-11 10:09 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c21edd64-396c-4c7c-86f8-79045321a528@acm.org \
--to=bvanassche@acm.org \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=anna.schumaker@netapp.com \
--cc=avihaih@nvidia.com \
--cc=axboe@fb.com \
--cc=bfields@fieldses.org \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jinpu.wang@ionos.com \
--cc=kbusch@kernel.org \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=maxg@mellanox.com \
--cc=mgurtovoy@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=pv-drivers@vmware.com \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=samba-technical@lists.samba.org \
--cc=santosh.shilimkar@oracle.com \
--cc=selvin.xavier@broadcom.com \
--cc=sfrench@samba.org \
--cc=shiraz.saleem@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=trond.myklebust@hammerspace.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).