[PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

[PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

[Will Deacon]

Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
arch timer on arm64") changed the rating of the MCT clockevents device
to be lower than the Arm architected timer and, in the process, replaced
a semicolon with a comma thanks to a silly copy-paste error.

Put the semicolon back so that the code looks more idiomatic and resolve
the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.

Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Will Deacon <will@kernel.org>
---

Although this doesn't have a functional impact and I'd normally not pay
too much attention to checkpatch warnings, the code is pretty weird as-is
and I didn't intend for that comma to be there!

 drivers/clocksource/exynos_mct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 5e3e96d3d1b9..77ebe960c8c7 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -467,7 +467,7 @@ static int exynos4_mct_starting_cpu(unsigned int cpu)
 	evt->tick_resume = set_state_shutdown;
 	evt->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT |
 			CLOCK_EVT_FEAT_PERCPU;
-	evt->rating = MCT_CLKEVENTS_RATING,
+	evt->rating = MCT_CLKEVENTS_RATING;
 
 	exynos4_mct_write(TICK_BASE_CNT, mevt->base + MCT_L_TCNTB_OFFSET);
 
-- 
2.34.0.rc0.344.g81b53c2807-goog

Re: [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

[Krzysztof Kozlowski]

On 03/11/2021 17:48, Will Deacon wrote:
> Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
> arch timer on arm64") changed the rating of the MCT clockevents device
> to be lower than the Arm architected timer and, in the process, replaced
> a semicolon with a comma thanks to a silly copy-paste error.
> 
> Put the semicolon back so that the code looks more idiomatic and resolve
> the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
> 
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> 
> Although this doesn't have a functional impact and I'd normally not pay
> too much attention to checkpatch warnings, the code is pretty weird as-is
> and I didn't intend for that comma to be there!
> 
>  drivers/clocksource/exynos_mct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

[tip: timers/core] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

[tip-bot2 for Will Deacon]

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     410fbda49cc9b2165e80b87880f164d9644b460d
Gitweb:        https://git.kernel.org/tip/410fbda49cc9b2165e80b87880f164d9644b460d
Author:        Will Deacon <will@kernel.org>
AuthorDate:    Wed, 03 Nov 2021 16:48:04 
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 09 Dec 2021 12:29:52 +01:00

clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
arch timer on arm64") changed the rating of the MCT clockevents device
to be lower than the Arm architected timer and, in the process, replaced
a semicolon with a comma thanks to a silly copy-paste error.

Put the semicolon back so that the code looks more idiomatic and resolve
the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.

Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Will Deacon <will@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20211103164804.30182-1-will@kernel.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/exynos_mct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 857cf12..6db3d55 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -467,7 +467,7 @@ static int exynos4_mct_starting_cpu(unsigned int cpu)
 	evt->tick_resume = set_state_shutdown;
 	evt->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT |
 			CLOCK_EVT_FEAT_PERCPU;
-	evt->rating = MCT_CLKEVENTS_RATING,
+	evt->rating = MCT_CLKEVENTS_RATING;
 
 	exynos4_mct_write(TICK_BASE_CNT, mevt->base + MCT_L_TCNTB_OFFSET);