* [PATCH] vfs: fs_context: Modify mismatched function name
@ 2022-10-20 3:40 Jiapeng Chong
2022-10-20 3:53 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-10-20 3:40 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
fs/fs_context.c:347: warning: expecting prototype for vfs_dup_fc_config(). Prototype was for vfs_dup_fs_context() instead.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2456
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/fs_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs_context.c b/fs/fs_context.c
index df04e5fc6d66..be45701cd998 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -340,7 +340,7 @@ void fc_drop_locked(struct fs_context *fc)
static void legacy_fs_context_free(struct fs_context *fc);
/**
- * vfs_dup_fc_config: Duplicate a filesystem context.
+ * vfs_dup_fs_context: Duplicate a filesystem context.
* @src_fc: The context to copy.
*/
struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vfs: fs_context: Modify mismatched function name
2022-10-20 3:40 [PATCH] vfs: fs_context: Modify mismatched function name Jiapeng Chong
@ 2022-10-20 3:53 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-10-20 3:53 UTC (permalink / raw)
To: Jiapeng Chong, viro; +Cc: linux-fsdevel, linux-kernel, Abaci Robot
Hi--
On 10/19/22 20:40, Jiapeng Chong wrote:
> No functional modification involved.
>
> fs/fs_context.c:347: warning: expecting prototype for vfs_dup_fc_config(). Prototype was for vfs_dup_fs_context() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2456
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/fs_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index df04e5fc6d66..be45701cd998 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -340,7 +340,7 @@ void fc_drop_locked(struct fs_context *fc)
> static void legacy_fs_context_free(struct fs_context *fc);
>
> /**
> - * vfs_dup_fc_config: Duplicate a filesystem context.
> + * vfs_dup_fs_context: Duplicate a filesystem context.
That is still not the correct kernel-doc format (or syntax).
The ':' should be a '-' instead.
Also, I see scripts/kernel-doc reporting 16 kernel-doc format
problems in this file. How about fixing more than just one of them, please.
fs_context.c:95: warning: No description found for return value of 'vfs_parse_fs
_param_source'
fs_context.c:128: warning: No description found for return value of 'vfs_parse_f
s_param'
fs_context.c:168: warning: Function parameter or member 'fc' not described in 'v
fs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'key' not described in '
vfs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'value' not described in
'vfs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'v_size' not described i
n 'vfs_parse_fs_string'
fs_context.c:168: warning: No description found for return value of 'vfs_parse_f
s_string'
fs_context.c:202: warning: Function parameter or member 'fc' not described in 'g
eneric_parse_monolithic'
fs_context.c:202: warning: Excess function parameter 'ctx' description in 'gener
ic_parse_monolithic'
fs_context.c:202: warning: No description found for return value of 'generic_par
se_monolithic'
fs_context.c:252: warning: No description found for return value of 'alloc_fs_co
ntext'
fs_context.c:340: warning: No description found for return value of 'vfs_dup_fs_
context'
fs_context.c:386: warning: Function parameter or member 'log' not described in '
logfc'
fs_context.c:386: warning: Function parameter or member 'prefix' not described i
n 'logfc'
fs_context.c:386: warning: Function parameter or member 'level' not described in
'logfc'
fs_context.c:386: warning: Excess function parameter 'fc' description in 'logfc'
16 warnings
> * @src_fc: The context to copy.
> */
> struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 3:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 3:40 [PATCH] vfs: fs_context: Modify mismatched function name Jiapeng Chong
2022-10-20 3:53 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).