* [PATCH] ata: Don't build PATA_CS5535 on UML
@ 2023-01-13 4:37 Peter Foley
2023-01-13 7:44 ` Randy Dunlap
2023-01-13 22:44 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Peter Foley @ 2023-01-13 4:37 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, linux-kernel, Peter Foley
This driver uses MSR functions that aren't implemented under UML.
Avoid building it to prevent tripping up allyesconfig.
e.g.
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3a3): undefined reference to `__tracepoint_read_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3d2): undefined reference to `__tracepoint_write_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x457): undefined reference to `__tracepoint_write_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x481): undefined reference to `do_trace_write_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4d5): undefined reference to `do_trace_write_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4f5): undefined reference to `do_trace_read_msr'
/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x51c): undefined reference to `do_trace_write_msr'
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index eceaec33af65..9695c4404e26 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -640,6 +640,7 @@ config PATA_CS5530
config PATA_CS5535
tristate "CS5535 PATA support (Experimental)"
depends on PCI && (X86_32 || (X86_64 && COMPILE_TEST))
+ depends on !UML
help
This option enables support for the NatSemi/AMD CS5535
companion chip used with the Geode processor family.
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230112-umide-18c116111232
Best regards,
--
Peter Foley <pefoley2@pefoley.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: Don't build PATA_CS5535 on UML
2023-01-13 4:37 [PATCH] ata: Don't build PATA_CS5535 on UML Peter Foley
@ 2023-01-13 7:44 ` Randy Dunlap
2023-01-13 22:44 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-01-13 7:44 UTC (permalink / raw)
To: Peter Foley, Damien Le Moal; +Cc: linux-ide, linux-kernel
Hi--
On 1/12/23 20:37, Peter Foley wrote:
> This driver uses MSR functions that aren't implemented under UML.
> Avoid building it to prevent tripping up allyesconfig.
>
> e.g.
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3a3): undefined reference to `__tracepoint_read_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3d2): undefined reference to `__tracepoint_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x457): undefined reference to `__tracepoint_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x481): undefined reference to `do_trace_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4d5): undefined reference to `do_trace_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4f5): undefined reference to `do_trace_read_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x51c): undefined reference to `do_trace_write_msr'
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
I have a similar patch on my system that I have never sent.
I think that PATA_CS5536 needs the same treatment.
Anyway:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index eceaec33af65..9695c4404e26 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -640,6 +640,7 @@ config PATA_CS5530
> config PATA_CS5535
> tristate "CS5535 PATA support (Experimental)"
> depends on PCI && (X86_32 || (X86_64 && COMPILE_TEST))
> + depends on !UML
> help
> This option enables support for the NatSemi/AMD CS5535
> companion chip used with the Geode processor family.
>
> ---
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> change-id: 20230112-umide-18c116111232
>
> Best regards,
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: Don't build PATA_CS5535 on UML
2023-01-13 4:37 [PATCH] ata: Don't build PATA_CS5535 on UML Peter Foley
2023-01-13 7:44 ` Randy Dunlap
@ 2023-01-13 22:44 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-01-13 22:44 UTC (permalink / raw)
To: Peter Foley; +Cc: linux-ide, linux-kernel
On 1/13/23 13:37, Peter Foley wrote:
> This driver uses MSR functions that aren't implemented under UML.
> Avoid building it to prevent tripping up allyesconfig.
>
> e.g.
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3a3): undefined reference to `__tracepoint_read_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3d2): undefined reference to `__tracepoint_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x457): undefined reference to `__tracepoint_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x481): undefined reference to `do_trace_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4d5): undefined reference to `do_trace_write_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4f5): undefined reference to `do_trace_read_msr'
> /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x51c): undefined reference to `do_trace_write_msr'
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
Applied to for-6.2-fixes with a slightly tweaked commit title.
Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-13 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 4:37 [PATCH] ata: Don't build PATA_CS5535 on UML Peter Foley
2023-01-13 7:44 ` Randy Dunlap
2023-01-13 22:44 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).