From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Keiichi Watanabe <keiichiw@chromium.org>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
jcliang@chromium.org, shik@chromium.org
Subject: Re: [PATCH v2] media: vivid: Support 480p for webcam capture
Date: Tue, 9 Oct 2018 15:33:48 +0100 [thread overview]
Message-ID: <c2d10472-021d-ab1e-4eb8-bb189ee80f5d@ideasonboard.com> (raw)
In-Reply-To: <20181009134339.233238-1-keiichiw@chromium.org>
Hi Keiichi,
Thank you for the patch update,
On 09/10/18 14:43, Keiichi Watanabe wrote:
> Support 640x480 as a frame size for video input devices of vivid.
>
> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
My concerns have been addressed,
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/vivid/vivid-vid-cap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c
> index 58e14dd1dcd3..6cf910a60ecf 100644
> --- a/drivers/media/platform/vivid/vivid-vid-cap.c
> +++ b/drivers/media/platform/vivid/vivid-vid-cap.c
> @@ -51,7 +51,7 @@ static const struct vivid_fmt formats_ovl[] = {
> };
>
> /* The number of discrete webcam framesizes */
> -#define VIVID_WEBCAM_SIZES 5
> +#define VIVID_WEBCAM_SIZES 6
> /* The number of discrete webcam frameintervals */
> #define VIVID_WEBCAM_IVALS (VIVID_WEBCAM_SIZES * 2)
>
> @@ -59,6 +59,7 @@ static const struct vivid_fmt formats_ovl[] = {
> static const struct v4l2_frmsize_discrete webcam_sizes[VIVID_WEBCAM_SIZES] = {
> { 320, 180 },
> { 640, 360 },
> + { 640, 480 },
> { 1280, 720 },
> { 1920, 1080 },
> { 3840, 2160 },
> @@ -74,9 +75,11 @@ static const struct v4l2_fract webcam_intervals[VIVID_WEBCAM_IVALS] = {
> { 1, 4 },
> { 1, 5 },
> { 1, 10 },
> + { 2, 25 },
> { 1, 15 },
> { 1, 25 },
> { 1, 30 },
> + { 1, 40 },
> { 1, 50 },
> { 1, 60 },
> };
>
--
Regards
--
Kieran
prev parent reply other threads:[~2018-10-09 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 13:43 [PATCH v2] media: vivid: Support 480p for webcam capture Keiichi Watanabe
2018-10-09 14:00 ` Hans Verkuil
2018-10-09 14:33 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d10472-021d-ab1e-4eb8-bb189ee80f5d@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=jcliang@chromium.org \
--cc=keiichiw@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=shik@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).