* [PATCH v2] media: vivid: Support 480p for webcam capture
@ 2018-10-09 13:43 Keiichi Watanabe
2018-10-09 14:00 ` Hans Verkuil
2018-10-09 14:33 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Keiichi Watanabe @ 2018-10-09 13:43 UTC (permalink / raw)
To: linux-media
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-kernel,
kieran.bingham, tfiga, jcliang, shik, Keiichi Watanabe
Support 640x480 as a frame size for video input devices of vivid.
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
---
drivers/media/platform/vivid/vivid-vid-cap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c
index 58e14dd1dcd3..6cf910a60ecf 100644
--- a/drivers/media/platform/vivid/vivid-vid-cap.c
+++ b/drivers/media/platform/vivid/vivid-vid-cap.c
@@ -51,7 +51,7 @@ static const struct vivid_fmt formats_ovl[] = {
};
/* The number of discrete webcam framesizes */
-#define VIVID_WEBCAM_SIZES 5
+#define VIVID_WEBCAM_SIZES 6
/* The number of discrete webcam frameintervals */
#define VIVID_WEBCAM_IVALS (VIVID_WEBCAM_SIZES * 2)
@@ -59,6 +59,7 @@ static const struct vivid_fmt formats_ovl[] = {
static const struct v4l2_frmsize_discrete webcam_sizes[VIVID_WEBCAM_SIZES] = {
{ 320, 180 },
{ 640, 360 },
+ { 640, 480 },
{ 1280, 720 },
{ 1920, 1080 },
{ 3840, 2160 },
@@ -74,9 +75,11 @@ static const struct v4l2_fract webcam_intervals[VIVID_WEBCAM_IVALS] = {
{ 1, 4 },
{ 1, 5 },
{ 1, 10 },
+ { 2, 25 },
{ 1, 15 },
{ 1, 25 },
{ 1, 30 },
+ { 1, 40 },
{ 1, 50 },
{ 1, 60 },
};
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] media: vivid: Support 480p for webcam capture
2018-10-09 13:43 [PATCH v2] media: vivid: Support 480p for webcam capture Keiichi Watanabe
@ 2018-10-09 14:00 ` Hans Verkuil
2018-10-09 14:33 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2018-10-09 14:00 UTC (permalink / raw)
To: Keiichi Watanabe, linux-media
Cc: Mauro Carvalho Chehab, linux-kernel, kieran.bingham, tfiga,
jcliang, shik
On 10/09/18 15:43, Keiichi Watanabe wrote:
> Support 640x480 as a frame size for video input devices of vivid.
>
> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> ---
> drivers/media/platform/vivid/vivid-vid-cap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c
> index 58e14dd1dcd3..6cf910a60ecf 100644
> --- a/drivers/media/platform/vivid/vivid-vid-cap.c
> +++ b/drivers/media/platform/vivid/vivid-vid-cap.c
> @@ -51,7 +51,7 @@ static const struct vivid_fmt formats_ovl[] = {
> };
>
> /* The number of discrete webcam framesizes */
> -#define VIVID_WEBCAM_SIZES 5
> +#define VIVID_WEBCAM_SIZES 6
> /* The number of discrete webcam frameintervals */
> #define VIVID_WEBCAM_IVALS (VIVID_WEBCAM_SIZES * 2)
>
> @@ -59,6 +59,7 @@ static const struct vivid_fmt formats_ovl[] = {
> static const struct v4l2_frmsize_discrete webcam_sizes[VIVID_WEBCAM_SIZES] = {
> { 320, 180 },
> { 640, 360 },
> + { 640, 480 },
> { 1280, 720 },
> { 1920, 1080 },
> { 3840, 2160 },
> @@ -74,9 +75,11 @@ static const struct v4l2_fract webcam_intervals[VIVID_WEBCAM_IVALS] = {
> { 1, 4 },
> { 1, 5 },
> { 1, 10 },
> + { 2, 25 },
> { 1, 15 },
> { 1, 25 },
> { 1, 30 },
> + { 1, 40 },
> { 1, 50 },
> { 1, 60 },
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] media: vivid: Support 480p for webcam capture
2018-10-09 13:43 [PATCH v2] media: vivid: Support 480p for webcam capture Keiichi Watanabe
2018-10-09 14:00 ` Hans Verkuil
@ 2018-10-09 14:33 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2018-10-09 14:33 UTC (permalink / raw)
To: Keiichi Watanabe, linux-media
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-kernel, tfiga, jcliang, shik
Hi Keiichi,
Thank you for the patch update,
On 09/10/18 14:43, Keiichi Watanabe wrote:
> Support 640x480 as a frame size for video input devices of vivid.
>
> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
My concerns have been addressed,
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/vivid/vivid-vid-cap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c
> index 58e14dd1dcd3..6cf910a60ecf 100644
> --- a/drivers/media/platform/vivid/vivid-vid-cap.c
> +++ b/drivers/media/platform/vivid/vivid-vid-cap.c
> @@ -51,7 +51,7 @@ static const struct vivid_fmt formats_ovl[] = {
> };
>
> /* The number of discrete webcam framesizes */
> -#define VIVID_WEBCAM_SIZES 5
> +#define VIVID_WEBCAM_SIZES 6
> /* The number of discrete webcam frameintervals */
> #define VIVID_WEBCAM_IVALS (VIVID_WEBCAM_SIZES * 2)
>
> @@ -59,6 +59,7 @@ static const struct vivid_fmt formats_ovl[] = {
> static const struct v4l2_frmsize_discrete webcam_sizes[VIVID_WEBCAM_SIZES] = {
> { 320, 180 },
> { 640, 360 },
> + { 640, 480 },
> { 1280, 720 },
> { 1920, 1080 },
> { 3840, 2160 },
> @@ -74,9 +75,11 @@ static const struct v4l2_fract webcam_intervals[VIVID_WEBCAM_IVALS] = {
> { 1, 4 },
> { 1, 5 },
> { 1, 10 },
> + { 2, 25 },
> { 1, 15 },
> { 1, 25 },
> { 1, 30 },
> + { 1, 40 },
> { 1, 50 },
> { 1, 60 },
> };
>
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-09 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 13:43 [PATCH v2] media: vivid: Support 480p for webcam capture Keiichi Watanabe
2018-10-09 14:00 ` Hans Verkuil
2018-10-09 14:33 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).