* [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs
@ 2018-09-26 11:57 Vignesh R
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
2018-09-26 11:57 ` [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
0 siblings, 2 replies; 5+ messages in thread
From: Vignesh R @ 2018-09-26 11:57 UTC (permalink / raw)
To: Rob Herring, Wolfram Sang
Cc: Vignesh R, Sekhar Nori, linux-i2c, devicetree, linux-kernel,
Nishanth Menon, Tero Kristo, linux-arm-kernel
Couple of patches to enable i2c-omap driver to be used with TI's new
AM654 platforms.
Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3
Documentation/devicetree/bindings/i2c/i2c-omap.txt | 1 +
drivers/i2c/busses/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.19.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
2018-09-26 11:57 [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
@ 2018-09-26 11:57 ` Vignesh R
2018-09-26 14:44 ` Peter Rosin
2018-09-26 11:57 ` [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
1 sibling, 1 reply; 5+ messages in thread
From: Vignesh R @ 2018-09-26 11:57 UTC (permalink / raw)
To: Rob Herring, Wolfram Sang
Cc: Vignesh R, Sekhar Nori, linux-i2c, devicetree, linux-kernel,
Nishanth Menon, Tero Kristo, linux-arm-kernel
AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
handle AM654 SoCs.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
index 7e49839d4124..11ce869d682d 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
@@ -2,7 +2,8 @@ I2C for OMAP platforms
Required properties :
- compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
- or "ti,omap4-i2c"
+ or "ti,omap4-i2c" for OMAP2+ SoCs
+- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
- ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
- #address-cells = <1>;
- #size-cells = <0>;
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3
2018-09-26 11:57 [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
@ 2018-09-26 11:57 ` Vignesh R
1 sibling, 0 replies; 5+ messages in thread
From: Vignesh R @ 2018-09-26 11:57 UTC (permalink / raw)
To: Rob Herring, Wolfram Sang
Cc: Vignesh R, Sekhar Nori, linux-i2c, devicetree, linux-kernel,
Nishanth Menon, Tero Kristo, linux-arm-kernel
Allow I2C_OMAP to be built for K3 platforms.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 451d4ae50e66..ac4b09642f63 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -751,7 +751,7 @@ config I2C_OCORES
config I2C_OMAP
tristate "OMAP I2C adapter"
- depends on ARCH_OMAP
+ depends on ARCH_OMAP || ARCH_K3
default y if MACH_OMAP_H3 || MACH_OMAP_OSK
help
If you say yes to this option, support will be included for the
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
@ 2018-09-26 14:44 ` Peter Rosin
2018-09-28 5:27 ` Vignesh R
0 siblings, 1 reply; 5+ messages in thread
From: Peter Rosin @ 2018-09-26 14:44 UTC (permalink / raw)
To: Vignesh R, Rob Herring, Wolfram Sang
Cc: Sekhar Nori, linux-i2c, devicetree, linux-kernel, Nishanth Menon,
Tero Kristo, linux-arm-kernel
On 2018-09-26 13:57, Vignesh R wrote:
> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
> handle AM654 SoCs.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> index 7e49839d4124..11ce869d682d 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> @@ -2,7 +2,8 @@ I2C for OMAP platforms
>
> Required properties :
> - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
> - or "ti,omap4-i2c"
> + or "ti,omap4-i2c" for OMAP2+ SoCs
> +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
^
be
Also, it looks bad with two 'compatible' entries in the properties list.
I think the trend is to list one valid compatible (plus fallbacks)
per line. So, you should consider reformatting, possibly like so:
- compatible : Must be one of
"ti,omap2420-i2c"
"ti,omap2430-i2c"
"ti,omap3-i2c"
"ti,omap4-i2c"
"ti,am654-i2c", "ti,omap4-i2c"
Cheers,
Peter
> - ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
> - #address-cells = <1>;
> - #size-cells = <0>;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
2018-09-26 14:44 ` Peter Rosin
@ 2018-09-28 5:27 ` Vignesh R
0 siblings, 0 replies; 5+ messages in thread
From: Vignesh R @ 2018-09-28 5:27 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Wolfram Sang
Cc: Nori, Sekhar, linux-i2c, devicetree, linux-kernel, Menon,
Nishanth, Kristo, Tero, linux-arm-kernel
On Wednesday 26 September 2018 08:14 PM, Peter Rosin wrote:
> On 2018-09-26 13:57, Vignesh R wrote:
>> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
>> handle AM654 SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> index 7e49839d4124..11ce869d682d 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> @@ -2,7 +2,8 @@ I2C for OMAP platforms
>>
>> Required properties :
>> - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
>> - or "ti,omap4-i2c"
>> + or "ti,omap4-i2c" for OMAP2+ SoCs
>> +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
> ^
> be
>
> Also, it looks bad with two 'compatible' entries in the properties list.
> I think the trend is to list one valid compatible (plus fallbacks)
> per line. So, you should consider reformatting, possibly like so:
>
> - compatible : Must be one of
> "ti,omap2420-i2c"
> "ti,omap2430-i2c"
> "ti,omap3-i2c"
> "ti,omap4-i2c"
> "ti,am654-i2c", "ti,omap4-i2c"
>
I have sent v2 with these changes. Thanks for the review!
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-28 5:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 11:57 [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
2018-09-26 14:44 ` Peter Rosin
2018-09-28 5:27 ` Vignesh R
2018-09-26 11:57 ` [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).