From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Ajit Pandey <ajitp@codeaurora.org>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
Date: Fri, 18 Sep 2020 17:21:37 +0530 [thread overview]
Message-ID: <c36dbcd7-4492-3598-68c0-f4aea1c1dabf@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=U1k7T6z=dZHYWFpnAw1bTptPjKXd7z9YuOQOsOFrXp-A@mail.gmail.com>
Thanks Mr. Doug for your time to review this patch!!
On 9/14/2020 11:11 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Sep 1, 2020 at 9:04 PM Srinivasa Rao Mandadapu
> <srivasam@codeaurora.org> wrote:
>> From: Ajit Pandey <ajitp@codeaurora.org>
>>
>> Add the I2S controller node to sc7180 dtsi.
>> Add pinmux for primary and secondary I2S.
>>
>> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
>> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>>
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 69 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 69 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index d46b383..db60ca5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -676,6 +676,36 @@
>> };
>> };
>>
>> + lpass_cpu: lpass@62f00000 {
>> + compatible = "qcom,sc7180-lpass-cpu";
>> +
>> + reg = <0 0x62f00000 0 0x29000>;
>> + reg-names = "lpass-lpaif";
>> +
>> + iommus = <&apps_smmu 0x1020 0>;
>> +
>> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
>> +
>> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_CORE_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>;
>> +
>> + clock-names = "pcnoc-sway-clk", "audio-core",
>> + "mclk0", "pcnoc-mport-clk",
>> + "mi2s-bit-clk0", "mi2s-bit-clk1";
>> +
>> +
>> + #sound-dai-cells = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "lpass-irq-lpaif";
>> + };
>> +
>> sdhc_1: sdhci@7c4000 {
> Your node is still sorted incorrectly. Nodes with unit addresses
> should be sorted numerically.
>
> The number 0x62f00000 is greater than the number 0x7c4000. Thus your
> node should not be placed above "sdhci@7c4000". It should be placed
> somewhere further down in the file.
Will place it accordingly.
>
>
>> compatible = "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
>> reg = <0 0x7c4000 0 0x1000>,
>> @@ -1721,6 +1751,45 @@
>> };
>> };
>>
>> + sec_mi2s_active: sec-mi2s-active {
>> + pinmux {
>> + pins = "gpio49", "gpio50", "gpio51";
>> + function = "mi2s_1";
>> + };
>> +
>> + pinconf {
>> + pins = "gpio49", "gpio50", "gpio51";;
> nit: double-semi-colon.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2020-09-18 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 4:04 [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver Srinivasa Rao Mandadapu
2020-09-02 13:58 ` kernel test robot
2020-09-14 17:41 ` Doug Anderson
2020-09-18 11:51 ` Srinivasa Rao Mandadapu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36dbcd7-4492-3598-68c0-f4aea1c1dabf@codeaurora.org \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).