* [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default
@ 2021-09-02 12:13 Eugen Hristev
2021-09-14 15:03 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Eugen Hristev @ 2021-09-02 12:13 UTC (permalink / raw)
To: nicolas.ferre
Cc: robh+dt, ludovic.desroches, devicetree, linux-arm-kernel,
linux-kernel, Eugen Hristev
Without a sensor node, the ISC will simply fail to probe, as the
corresponding port node is missing.
It is then logical to disable the node in the devicetree.
If we add a port with a connection to a sensor endpoint, ISC can be enabled.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index 614999dcb990..cd4672501add 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -71,7 +71,6 @@ apb {
isc: isc@f0008000 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
- status = "okay";
};
qspi1: spi@f0024000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default
2021-09-02 12:13 [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default Eugen Hristev
@ 2021-09-14 15:03 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2021-09-14 15:03 UTC (permalink / raw)
To: Eugen Hristev
Cc: robh+dt, ludovic.desroches, devicetree, linux-arm-kernel, linux-kernel
On 02/09/2021 at 14:13, Eugen Hristev wrote:
> Without a sensor node, the ISC will simply fail to probe, as the
> corresponding port node is missing.
> It is then logical to disable the node in the devicetree.
> If we add a port with a connection to a sensor endpoint, ISC can be enabled.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Makes sense:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
And queued for at91-fixes in 5.15 as there is no point continuing to
have a failing probe on this board.
Thanks, best regards,
Nicolas
> ---
> arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> index 614999dcb990..cd4672501add 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> @@ -71,7 +71,6 @@ apb {
> isc: isc@f0008000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
> - status = "okay";
> };
>
> qspi1: spi@f0024000 {
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-14 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 12:13 [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default Eugen Hristev
2021-09-14 15:03 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).