linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too
@ 2020-03-04  2:18 Tony W Wang-oc
  2020-03-04 17:13 ` Sean Christopherson
  0 siblings, 1 reply; 5+ messages in thread
From: Tony W Wang-oc @ 2020-03-04  2:18 UTC (permalink / raw)
  To: tglx, mingo, bp, hpa, x86, linux-kernel
  Cc: DavidWang, CooperYan, QiyuanWang, HerryYang

New Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
Prevention) feature. So, modify X86_UMIP depends on Zhaoxin CPUs too.

Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
---
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 16a4b39..ca4beb8 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1877,7 +1877,7 @@ config X86_SMAP
 
 config X86_UMIP
 	def_bool y
-	depends on CPU_SUP_INTEL || CPU_SUP_AMD
+	depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN
 	prompt "User Mode Instruction Prevention" if EXPERT
 	---help---
 	  User Mode Instruction Prevention (UMIP) is a security feature in
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too
  2020-03-04  2:18 [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too Tony W Wang-oc
@ 2020-03-04 17:13 ` Sean Christopherson
  2020-03-05  3:40   ` Tony W Wang-oc
  0 siblings, 1 reply; 5+ messages in thread
From: Sean Christopherson @ 2020-03-04 17:13 UTC (permalink / raw)
  To: Tony W Wang-oc
  Cc: tglx, mingo, bp, hpa, x86, linux-kernel, DavidWang, CooperYan,
	QiyuanWang, HerryYang

On Wed, Mar 04, 2020 at 10:18:05AM +0800, Tony W Wang-oc wrote:
> New Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
> Prevention) feature. So, modify X86_UMIP depends on Zhaoxin CPUs too.
> 
> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> ---
>  arch/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 16a4b39..ca4beb8 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1877,7 +1877,7 @@ config X86_SMAP
>  
>  config X86_UMIP
>  	def_bool y
> -	depends on CPU_SUP_INTEL || CPU_SUP_AMD
> +	depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN

The changelog only mentions Zhaoxin, but this also adds Centaur...

>  	prompt "User Mode Instruction Prevention" if EXPERT
>  	---help---
>  	  User Mode Instruction Prevention (UMIP) is a security feature in
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too
  2020-03-04 17:13 ` Sean Christopherson
@ 2020-03-05  3:40   ` Tony W Wang-oc
  2020-03-05 15:59     ` Sean Christopherson
  0 siblings, 1 reply; 5+ messages in thread
From: Tony W Wang-oc @ 2020-03-05  3:40 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: tglx, mingo, bp, hpa, x86, linux-kernel, DavidWang, CooperYan,
	QiyuanWang, HerryYang


On 05/03/2020 01:13, Sean Christopherson wrote:
> On Wed, Mar 04, 2020 at 10:18:05AM +0800, Tony W Wang-oc wrote:
>> New Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
>> Prevention) feature. So, modify X86_UMIP depends on Zhaoxin CPUs too.
>>
>> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
>> ---
>>  arch/x86/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 16a4b39..ca4beb8 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -1877,7 +1877,7 @@ config X86_SMAP
>>  
>>  config X86_UMIP
>>  	def_bool y
>> -	depends on CPU_SUP_INTEL || CPU_SUP_AMD
>> +	depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN
> 
> The changelog only mentions Zhaoxin, but this also adds Centaur...

Sorry for this. Some Centaur family 7 CPUs also support the UMIP
feature, so will resend this patch as a patch series.

Sincerely
TonyWWang-oc
> 
>>  	prompt "User Mode Instruction Prevention" if EXPERT
>>  	---help---
>>  	  User Mode Instruction Prevention (UMIP) is a security feature in
>> -- 
>> 2.7.4
>>
> .
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too
  2020-03-05  3:40   ` Tony W Wang-oc
@ 2020-03-05 15:59     ` Sean Christopherson
  2020-03-06  9:14       ` Tony W Wang-oc
  0 siblings, 1 reply; 5+ messages in thread
From: Sean Christopherson @ 2020-03-05 15:59 UTC (permalink / raw)
  To: Tony W Wang-oc
  Cc: tglx, mingo, bp, hpa, x86, linux-kernel, DavidWang, CooperYan,
	QiyuanWang, HerryYang

On Thu, Mar 05, 2020 at 11:40:02AM +0800, Tony W Wang-oc wrote:
> 
> On 05/03/2020 01:13, Sean Christopherson wrote:
> > On Wed, Mar 04, 2020 at 10:18:05AM +0800, Tony W Wang-oc wrote:
> >> New Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
> >> Prevention) feature. So, modify X86_UMIP depends on Zhaoxin CPUs too.
> >>
> >> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> >> ---
> >>  arch/x86/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> >> index 16a4b39..ca4beb8 100644
> >> --- a/arch/x86/Kconfig
> >> +++ b/arch/x86/Kconfig
> >> @@ -1877,7 +1877,7 @@ config X86_SMAP
> >>  
> >>  config X86_UMIP
> >>  	def_bool y
> >> -	depends on CPU_SUP_INTEL || CPU_SUP_AMD
> >> +	depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN
> > 
> > The changelog only mentions Zhaoxin, but this also adds Centaur...
> 
> Sorry for this. Some Centaur family 7 CPUs also support the UMIP
> feature, so will resend this patch as a patch series.

Oooh, can you point me at architectural documentation for Centaur family 7?
I've been trying to track down Centaur documentation for CPUID behavior.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too
  2020-03-05 15:59     ` Sean Christopherson
@ 2020-03-06  9:14       ` Tony W Wang-oc
  0 siblings, 0 replies; 5+ messages in thread
From: Tony W Wang-oc @ 2020-03-06  9:14 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: tglx, mingo, bp, hpa, x86, linux-kernel, DavidWang, CooperYan,
	QiyuanWang, HerryYang

On 05/03/2020 23:59, Sean Christopherson wrote:
> On Thu, Mar 05, 2020 at 11:40:02AM +0800, Tony W Wang-oc wrote:
>>
>> On 05/03/2020 01:13, Sean Christopherson wrote:
>>> On Wed, Mar 04, 2020 at 10:18:05AM +0800, Tony W Wang-oc wrote:
>>>> New Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
>>>> Prevention) feature. So, modify X86_UMIP depends on Zhaoxin CPUs too.
>>>>
>>>> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
>>>> ---
>>>>  arch/x86/Kconfig | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>>>> index 16a4b39..ca4beb8 100644
>>>> --- a/arch/x86/Kconfig
>>>> +++ b/arch/x86/Kconfig
>>>> @@ -1877,7 +1877,7 @@ config X86_SMAP
>>>>  
>>>>  config X86_UMIP
>>>>  	def_bool y
>>>> -	depends on CPU_SUP_INTEL || CPU_SUP_AMD
>>>> +	depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN
>>>
>>> The changelog only mentions Zhaoxin, but this also adds Centaur...
>>
>> Sorry for this. Some Centaur family 7 CPUs also support the UMIP
>> feature, so will resend this patch as a patch series.
> 
> Oooh, can you point me at architectural documentation for Centaur family 7?
> I've been trying to track down Centaur documentation for CPUID behavior.
> .
> 

Centaur uses CPUID.(EAX=7,ECX=0):ECX[bit 2] indicates UMIP feature, that
is compatible with Intel's UMIP implementation.

Sincerely
TonyWWang-oc

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-06  9:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04  2:18 [PATCH] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs too Tony W Wang-oc
2020-03-04 17:13 ` Sean Christopherson
2020-03-05  3:40   ` Tony W Wang-oc
2020-03-05 15:59     ` Sean Christopherson
2020-03-06  9:14       ` Tony W Wang-oc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).