linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description
@ 2020-02-20 14:08 Stefano Garzarella
  2020-02-20 16:19 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Stefano Garzarella @ 2020-02-20 14:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: io-uring, linux-kernel

In the kernel we are using msecs_to_jiffies() to convert the
'sq_thread_idle' parameter, provided by the user, in jiffies.
So, the value is interpreted in milliseconds and not microseconds.

Fixes: 59bb09c553eb ("man: add io_uring_setup.2 man page")
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
 man/io_uring_setup.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/io_uring_setup.2 b/man/io_uring_setup.2
index 4057e4b..20c67dc 100644
--- a/man/io_uring_setup.2
+++ b/man/io_uring_setup.2
@@ -82,7 +82,7 @@ doing a single system call.
 
 If the kernel thread is idle for more than
 .I sq_thread_idle
-microseconds, it will set the
+milliseconds, it will set the
 .B IORING_SQ_NEED_WAKEUP
 bit in the
 .I flags
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description
  2020-02-20 14:08 [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description Stefano Garzarella
@ 2020-02-20 16:19 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-02-20 16:19 UTC (permalink / raw)
  To: Stefano Garzarella; +Cc: io-uring, linux-kernel

On 2/20/20 7:08 AM, Stefano Garzarella wrote:
> In the kernel we are using msecs_to_jiffies() to convert the
> 'sq_thread_idle' parameter, provided by the user, in jiffies.
> So, the value is interpreted in milliseconds and not microseconds.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-20 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 14:08 [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description Stefano Garzarella
2020-02-20 16:19 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).