* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu, linux-arm-kernel, linux-rockchip, Heiko Stübner,
Jörg Rödel
Cc: LKML, kernel-janitors, Rafael J. Wysocki, Aditya Pakki,
Kangjie Lu, Navid Emamdoost, Stephen McCamant
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-18 7:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 7:00 iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).