* [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values
@ 2020-05-07 18:15 Faiz Abbas
2020-05-15 9:37 ` Faiz Abbas
2020-05-15 10:14 ` Tero Kristo
0 siblings, 2 replies; 4+ messages in thread
From: Faiz Abbas @ 2020-05-07 18:15 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: robh+dt, nm, t-kristo, faiz_abbas
According to the latest AM65x Data Manual[1], a different output tap
delay value is optimum for a given speed mode. Update these values.
[1] http://www.ti.com/lit/gpn/am6526
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
v2: Rebased to the latest mainline kernel
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 11887c72f23a..6cd9701e4ead 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -244,7 +244,17 @@
interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
mmc-ddr-1_8v;
mmc-hs200-1_8v;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-mmc-hs = <0x0>;
+ ti,otap-del-sel-sd-hs = <0x0>;
+ ti,otap-del-sel-sdr12 = <0x0>;
+ ti,otap-del-sel-sdr25 = <0x0>;
+ ti,otap-del-sel-sdr50 = <0x8>;
+ ti,otap-del-sel-sdr104 = <0x5>;
+ ti,otap-del-sel-ddr50 = <0x5>;
+ ti,otap-del-sel-ddr52 = <0x5>;
+ ti,otap-del-sel-hs200 = <0x5>;
+ ti,otap-del-sel-hs400 = <0x0>;
ti,trm-icp = <0x8>;
dma-coherent;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values
2020-05-07 18:15 [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values Faiz Abbas
@ 2020-05-15 9:37 ` Faiz Abbas
2020-05-15 10:14 ` Tero Kristo
1 sibling, 0 replies; 4+ messages in thread
From: Faiz Abbas @ 2020-05-15 9:37 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel; +Cc: robh+dt, nm, t-kristo
Tero,
On 07/05/20 11:45 pm, Faiz Abbas wrote:
> According to the latest AM65x Data Manual[1], a different output tap
> delay value is optimum for a given speed mode. Update these values.
>
> [1] http://www.ti.com/lit/gpn/am6526
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> v2: Rebased to the latest mainline kernel
>
Gentle ping.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values
2020-05-07 18:15 [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values Faiz Abbas
2020-05-15 9:37 ` Faiz Abbas
@ 2020-05-15 10:14 ` Tero Kristo
2020-05-19 7:30 ` Faiz Abbas
1 sibling, 1 reply; 4+ messages in thread
From: Tero Kristo @ 2020-05-15 10:14 UTC (permalink / raw)
To: Faiz Abbas, linux-kernel, devicetree, linux-arm-kernel; +Cc: robh+dt, nm
On 07/05/2020 21:15, Faiz Abbas wrote:
> According to the latest AM65x Data Manual[1], a different output tap
> delay value is optimum for a given speed mode. Update these values.
>
> [1] http://www.ti.com/lit/gpn/am6526
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> v2: Rebased to the latest mainline kernel
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 11887c72f23a..6cd9701e4ead 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -244,7 +244,17 @@
> interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> mmc-ddr-1_8v;
> mmc-hs200-1_8v;
> - ti,otap-del-sel = <0x2>;
> + ti,otap-del-sel-legacy = <0x0>;
> + ti,otap-del-sel-mmc-hs = <0x0>;
> + ti,otap-del-sel-sd-hs = <0x0>;
> + ti,otap-del-sel-sdr12 = <0x0>;
> + ti,otap-del-sel-sdr25 = <0x0>;
> + ti,otap-del-sel-sdr50 = <0x8>;
> + ti,otap-del-sel-sdr104 = <0x5>;
Isn't this wrong? Doc claims the value for sdr104 should be 0x7?
-Tero
> + ti,otap-del-sel-ddr50 = <0x5>;
> + ti,otap-del-sel-ddr52 = <0x5>;
> + ti,otap-del-sel-hs200 = <0x5>;
> + ti,otap-del-sel-hs400 = <0x0>;
> ti,trm-icp = <0x8>;
> dma-coherent;
> };
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values
2020-05-15 10:14 ` Tero Kristo
@ 2020-05-19 7:30 ` Faiz Abbas
0 siblings, 0 replies; 4+ messages in thread
From: Faiz Abbas @ 2020-05-19 7:30 UTC (permalink / raw)
To: Tero Kristo, linux-kernel, devicetree, linux-arm-kernel; +Cc: robh+dt, nm
Hi Tero,
On 15/05/20 3:44 pm, Tero Kristo wrote:
> On 07/05/2020 21:15, Faiz Abbas wrote:
>> According to the latest AM65x Data Manual[1], a different output tap
>> delay value is optimum for a given speed mode. Update these values.
>>
>> [1] http://www.ti.com/lit/gpn/am6526
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>> v2: Rebased to the latest mainline kernel
>>
>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> index 11887c72f23a..6cd9701e4ead 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> @@ -244,7 +244,17 @@
>> interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>> mmc-ddr-1_8v;
>> mmc-hs200-1_8v;
>> - ti,otap-del-sel = <0x2>;
>> + ti,otap-del-sel-legacy = <0x0>;
>> + ti,otap-del-sel-mmc-hs = <0x0>;
>> + ti,otap-del-sel-sd-hs = <0x0>;
>> + ti,otap-del-sel-sdr12 = <0x0>;
>> + ti,otap-del-sel-sdr25 = <0x0>;
>> + ti,otap-del-sel-sdr50 = <0x8>;
>> + ti,otap-del-sel-sdr104 = <0x5>;
>
> Isn't this wrong? Doc claims the value for sdr104 should be 0x7?
>
Yes. There seems to be an update to the document since I last updated the value.
Thanks for catching. I will post another version soon.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 7:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 18:15 [PATCH v2] arm64: dts: ti: k3-am654-main: Update otap-del-sel values Faiz Abbas
2020-05-15 9:37 ` Faiz Abbas
2020-05-15 10:14 ` Tero Kristo
2020-05-19 7:30 ` Faiz Abbas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).