From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
will@kernel.org, robh@kernel.org, mingo@redhat.com,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
sandipan.das@amd.com, ananth.narayan@amd.com,
kim.phillips@amd.com, santosh.shukla@amd.com,
ravi.bangoria@amd.com
Subject: Re: [PATCH] perf: Rewrite core context handling
Date: Thu, 1 Sep 2022 16:05:53 +0530 [thread overview]
Message-ID: <c5a6aea9-4f3a-495e-78fa-e426de9b0496@amd.com> (raw)
In-Reply-To: <YwzP+AFWCx4Ni/kx@hirez.programming.kicks-ass.net>
On 29-Aug-22 8:10 PM, Peter Zijlstra wrote:
> On Mon, Aug 29, 2022 at 02:04:33PM +0200, Peter Zijlstra wrote:
>> On Mon, Aug 29, 2022 at 05:03:47PM +0530, Ravi Bangoria wrote:
>>> @@ -12598,6 +12590,7 @@ EXPORT_SYMBOL_GPL(perf_event_create_kernel_counter);
>>>
>>> void perf_pmu_migrate_context(struct pmu *pmu, int src_cpu, int dst_cpu)
>>> {
>>> +#if 0 // XXX buggered - cpu hotplug, who cares
>>> struct perf_event_context *src_ctx;
>>> struct perf_event_context *dst_ctx;
>>> struct perf_event *event, *tmp;
>>> @@ -12658,6 +12651,7 @@ void perf_pmu_migrate_context(struct pmu *pmu, int src_cpu, int dst_cpu)
>>> }
>>> mutex_unlock(&dst_ctx->mutex);
>>> mutex_unlock(&src_ctx->mutex);
>>> +#endif
>>> }
>>> EXPORT_SYMBOL_GPL(perf_pmu_migrate_context);
>>>
>>
>> Note to self; fix this :-) I'll see if I have time for that later today.
>
> Urgh, while going through that it appears the whole refcounting thing
> isn't fully done either.
Not sure I follow. Can you please elaborate.
Thanks,
Ravi
next prev parent reply other threads:[~2022-09-01 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 11:33 [PATCH] perf: Rewrite core context handling Ravi Bangoria
2022-08-29 12:04 ` Peter Zijlstra
2022-08-29 14:40 ` Peter Zijlstra
2022-09-01 10:35 ` Ravi Bangoria [this message]
2022-09-01 11:29 ` Peter Zijlstra
2022-09-05 4:40 ` Ravi Bangoria
2022-09-06 5:50 ` Ravi Bangoria
2022-10-10 10:23 ` Peter Zijlstra
2022-10-10 11:01 ` Ravi Bangoria
2022-09-07 11:28 ` Ravi Bangoria
2022-10-10 10:14 ` Peter Zijlstra
2022-10-10 10:59 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a6aea9-4f3a-495e-78fa-e426de9b0496@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=catalin.marinas@arm.com \
--cc=eranian@google.com \
--cc=frederic@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=songliubraving@fb.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).