* [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
@ 2017-06-20 20:12 Arnd Bergmann
2017-06-21 21:50 ` Stephen Boyd
2017-06-23 0:39 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-20 20:12 UTC (permalink / raw)
To: Santosh Shilimkar, Michael Turquette, Stephen Boyd
Cc: Arnd Bergmann, Tero Kristo, linux-kernel, linux-clk
CONFIG_COMPILE_TEST allows building a configuration without
TI_SCI_PROTOCOL, which then fails to link:
drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
This makes it a hard dependency. Right now, that means we can't
actually compile-test the driver unless ARCH_KEYSTONE is set as
well, but we can fix that by allowing TI_MESSAGE_MANAGER to
be selected for COMPILE_TEST as well.
Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/keystone/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/keystone/Kconfig b/drivers/clk/keystone/Kconfig
index 1fea328a36fe..7e9f0176578a 100644
--- a/drivers/clk/keystone/Kconfig
+++ b/drivers/clk/keystone/Kconfig
@@ -8,7 +8,8 @@ config COMMON_CLK_KEYSTONE
config TI_SCI_CLK
tristate "TI System Control Interface clock drivers"
depends on (ARCH_KEYSTONE || COMPILE_TEST) && OF
- default TI_SCI_PROTOCOL
+ depends on TI_SCI_PROTOCOL
+ default ARCH_KEYSTONE
---help---
This adds the clock driver support over TI System Control Interface.
If you wish to use clock resources from the PMMC firmware, say Y.
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
2017-06-20 20:12 [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Arnd Bergmann
@ 2017-06-21 21:50 ` Stephen Boyd
2017-06-22 6:09 ` Tero Kristo
2017-06-23 0:39 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2017-06-21 21:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Santosh Shilimkar, Michael Turquette, Tero Kristo, linux-kernel,
linux-clk
On 06/20, Arnd Bergmann wrote:
> CONFIG_COMPILE_TEST allows building a configuration without
> TI_SCI_PROTOCOL, which then fails to link:
>
> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>
> This makes it a hard dependency. Right now, that means we can't
> actually compile-test the driver unless ARCH_KEYSTONE is set as
> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
> be selected for COMPILE_TEST as well.
>
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Looks ok to me. Tero?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
2017-06-21 21:50 ` Stephen Boyd
@ 2017-06-22 6:09 ` Tero Kristo
0 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2017-06-22 6:09 UTC (permalink / raw)
To: Stephen Boyd, Arnd Bergmann
Cc: Santosh Shilimkar, Michael Turquette, linux-kernel, linux-clk
On 22/06/17 00:50, Stephen Boyd wrote:
> On 06/20, Arnd Bergmann wrote:
>> CONFIG_COMPILE_TEST allows building a configuration without
>> TI_SCI_PROTOCOL, which then fails to link:
>>
>> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
>> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>>
>> This makes it a hard dependency. Right now, that means we can't
>> actually compile-test the driver unless ARCH_KEYSTONE is set as
>> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
>> be selected for COMPILE_TEST as well.
>>
>> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>
> Looks ok to me. Tero?
>
Yeah, looks okay to me also, been traveling so sorry about the latency.
Acked-by: Tero Kristo <t-kristo@ti.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
2017-06-20 20:12 [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Arnd Bergmann
2017-06-21 21:50 ` Stephen Boyd
@ 2017-06-23 0:39 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2017-06-23 0:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Santosh Shilimkar, Michael Turquette, Tero Kristo, linux-kernel,
linux-clk
On 06/20, Arnd Bergmann wrote:
> CONFIG_COMPILE_TEST allows building a configuration without
> TI_SCI_PROTOCOL, which then fails to link:
>
> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>
> This makes it a hard dependency. Right now, that means we can't
> actually compile-test the driver unless ARCH_KEYSTONE is set as
> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
> be selected for COMPILE_TEST as well.
>
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-23 0:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-20 20:12 [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Arnd Bergmann
2017-06-21 21:50 ` Stephen Boyd
2017-06-22 6:09 ` Tero Kristo
2017-06-23 0:39 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).