From: Hugh Dickins <hughd@google.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
Vlastimil Babka <vbabka@suse.cz>,
syzbot <syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [mm?] kernel BUG in vma_replace_policy
Date: Fri, 15 Sep 2023 19:43:58 -0700 (PDT) [thread overview]
Message-ID: <c5c51578-efdc-7de-2238-4039fb1b6c36@google.com> (raw)
In-Reply-To: <CAJuCfpE8jnvL23W6fY4_HZf-969aEgvR3-LGRTUC-SFhPFju+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2568 bytes --]
On Fri, 15 Sep 2023, Suren Baghdasaryan wrote:
> On Fri, Sep 15, 2023 at 9:09 AM Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > Thanks for the feedback, Hugh!
> > Yeah, this positive err handling is kinda weird. If this behavior (do
> > as much as possible even if we fail eventually) is specific to mbind()
> > then we could keep walk_page_range() as is and lock the VMAs inside
> > the loop that calls mbind_range() with a condition that ret is
> > positive. That would be the simplest solution IMHO. But if we expect
> > walk_page_range() to always apply requested page_walk_lock policy to
> > all VMAs even if some mm_walk_ops returns a positive error somewhere
> > in the middle of the walk then my fix would work for that. So, to me
> > the important question is how we want walk_page_range() to behave in
> > these conditions. I think we should answer that first and document
> > that. Then the fix will be easy.
>
> I looked at all the cases where we perform page walk while locking
> VMAs and mbind() seems to be the only one that would require
> walk_page_range() to lock all VMAs even for a failed walk.
Yes, I can well believe that.
> So, I suggest this fix instead and I can also document that if
> walk_page_range() fails it might not apply page_walk_lock policy to
> the VMAs.
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 42b5567e3773..cbc584e9b6ca 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1342,6 +1342,9 @@ static long do_mbind(unsigned long start,
> unsigned long len,
> vma_iter_init(&vmi, mm, start);
> prev = vma_prev(&vmi);
> for_each_vma_range(vmi, vma, end) {
> + /* If queue_pages_range failed then not all VMAs
> might be locked */
> + if (ret)
> + vma_start_write(vma);
> err = mbind_range(&vmi, vma, &prev, start, end, new);
> if (err)
> break;
>
> If this looks good I'll post the patch. Matthew, Hugh, anyone else?
Yes, I do prefer this, to adding those pos ret mods into the generic
pagewalk. The "if (ret)" above being just a minor optimization, that
I would probably not have bothered with (does it even save any atomics?)
- but I guess it helps as documentation.
I think it's quite likely that mbind() will be changed sooner or later
not to need this; but it's much the best to fix this vma locking issue
urgently as above, without depending on any mbind() behavioral discussions.
Thanks,
Hugh
next prev parent reply other threads:[~2023-09-16 2:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 1:03 [syzbot] [mm?] kernel BUG in vma_replace_policy syzbot
[not found] ` <20230906061902.591996-1-eadavis@sina.com>
2023-09-06 12:06 ` [PATCH] mm: as the same logic with queue_pages_range Matthew Wilcox
2023-09-12 5:20 ` kernel test robot
2023-09-13 9:10 ` [LTP] " Cyril Hrubis
2023-09-08 18:04 ` [syzbot] [mm?] kernel BUG in vma_replace_policy syzbot
2023-09-12 5:30 ` Matthew Wilcox
2023-09-12 6:09 ` syzbot
2023-09-12 14:55 ` Matthew Wilcox
2023-09-12 15:03 ` Suren Baghdasaryan
2023-09-12 16:00 ` Suren Baghdasaryan
2023-09-13 16:05 ` Suren Baghdasaryan
2023-09-13 16:46 ` Suren Baghdasaryan
2023-09-14 18:20 ` Suren Baghdasaryan
2023-09-14 19:09 ` Matthew Wilcox
2023-09-14 20:00 ` Suren Baghdasaryan
2023-09-14 20:53 ` Suren Baghdasaryan
2023-09-14 21:24 ` Matthew Wilcox
2023-09-14 22:21 ` Suren Baghdasaryan
2023-09-15 4:26 ` Hugh Dickins
2023-09-15 16:09 ` Suren Baghdasaryan
2023-09-15 18:05 ` Suren Baghdasaryan
2023-09-16 2:43 ` Hugh Dickins [this message]
2023-09-18 21:20 ` Suren Baghdasaryan
2023-09-15 18:26 ` Matthew Wilcox
2023-09-16 2:54 ` Hugh Dickins
2023-09-16 1:35 ` Yang Shi
2023-09-16 3:57 ` Hugh Dickins
2023-09-18 22:34 ` Yang Shi
2023-09-19 0:34 ` Hugh Dickins
[not found] <20230909034207.5816-1-hdanton@sina.com>
2023-09-09 4:43 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c51578-efdc-7de-2238-4039fb1b6c36@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shy828301@gmail.com \
--cc=surenb@google.com \
--cc=syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).